For historical reasons we had some directives specified in the server.tpl.php, but since now recommended Dotdeb Nginx build (for Debian Squeeze) includes some of them in the main /etc/nginx/nginx.conf config file, it breaks things with fatal errors and requires removing them manually from /etc/nginx/nginx.conf, so we need to sync our config to avoid this.

Comments

omega8cc’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mikl’s picture

Status: Closed (fixed) » Needs review

This issue and it associated commits does a lot more than it says on the tin.

For one, it quadruples the value of the worker_connections setting, a change that is probably only beneficial for the largest Ægir/Barracuda deployments. For the rest of us, it is probably a small performance penalty and causes increased RAM usage.

Worse still, the change also introduces a `use epoll;` statement. This is a Linux-specific option. There’s no telling what nginx will do if you try to load epoll on a platform that doesn’t support it, but it’s probably not a something beneficial.

I’d recommend that the `use epoll` statement be removed soonest, and I think you should consider whether the quadrupling of worker_connections is the right setting for Aegir core.

omega8cc’s picture

Status: Needs review » Closed (fixed)

You have missed something. The included here (and updated) nginx.conf file is an *example* only. Provision will not overwrite your own /etc/nginx/nginx.conf file. It is included only for reference but not used anywhere. It has been included as a part of this commit because of the context with changes introduced in the server.tpl.php template.

  • Commit c4eed04 on dev-nginx-6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by omega8cc:
    Issue #1534306 by omega8cc - Duplicate directives in the Nginx config...
  • Commit abaa275 on dev-drupal-8, dev-nginx-6.x-1.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by omega8cc:
    Issue #1534306 by omega8cc - Duplicate directives in the Nginx config...