Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
@Jeff Burnz added this to Genesis last year. Just a simple way to add fieldsets to the advanced form. I just ported it to D8.
It's definitely related to #504962: Provide a compound form element with accessible labels
Comment | File | Size | Author |
---|---|---|---|
#13 | Screen Shot 2013-03-28 at 5.38.41 PM.png | 80.92 KB | mgifford |
#6 | Advanced_Search_Fieldsets-6.patch | 2.58 KB | mgifford |
#3 | Screen Shot 2012-06-16 at 12.57.22 PM.png | 58.06 KB | bowersox |
Advanced_Search_Fieldsets-1.patch | 2.51 KB | mgifford | |
Comments
Comment #1
Everett Zufelt CreditAttribution: Everett Zufelt commentedCan you please provide a description of the problem (perhaps with example markup) tha your patch attempts to solve?
Comment #2
mgiffordThis is following from @Jeff Burnz's code in Genesis where he added fieldsets to the advanced search form.
It could well be that we've got a solution for this in Core without it. The checkboxes are certainly one place where we should expect to see core be able to deliver.
Jeff also grouped keyword fields together.
Comment #3
bowersox CreditAttribution: bowersox commentedThe only place that needs a fieldset is the group of checkboxes called "Only of the type(s)". Screenshot attached showing where this appears.
Comment #4
mgiffordThis should have been checked by the bot.
Comment #6
mgiffordJust a re-roll.
Comment #7
mgifford#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.
Comment #8
mgiffordseems good.
Comment #9
mgifford#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.
Comment #10
mgifford#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.
Comment #11
mgifford#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.
Comment #12
mgiffordI'd just like to add that this one is totally trivial to test on SimplyTest.me.
Comment #13
mgiffordYup. They work:
That's highlighting with the WAVE Toolbar too. This patch just addresses the fieldsets.
Someone else has to review the code.
Comment #14
jessebeach CreditAttribution: jessebeach commentedCode looks good. It's just a change to introduce fieldsets into the HTML and it's done well. Setting to RTBC.
Comment #15
mgiffordThanks Jesse!
Comment #16
xjm#6: Advanced_Search_Fieldsets-6.patch queued for re-testing.
Comment #17
alexpottCommitted 288619 and pushed to 8.x. Thanks!