Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Both Marvin and Chameleon are now ready for RTL languages.
You can test both themes by logging in to http://dev.drupal.org.il with user marvin or chameleon respectively. password is the same as the user name.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | admin.jpg | 134.24 KB | druvision |
| #7 | marvin-granparadiso-a4.png | 74.43 KB | yhager |
| #3 | druplicon-watermark-rtl.png | 2.35 KB | yhager |
| #2 | marvin-rtl.0.patch | 6.44 KB | yhager |
| marvin-rtl.patch | 6.09 KB | yhager | |
Comments
Comment #1
Gábor HojtsyBy reviewing the patch, this looks quite nice. By reviewing the site:
- Marvin has a page background image, which should be different for RTL themes (it is cut off on the right, while this should be cut off on the left I guess)
- Chameleon has no such problems obviously
- I bet the Marvin and Chameleon node links borders touching the text directly is also the same Firefox bug
Would be nice to have others review this.
Comment #2
yhager CreditAttribution: yhager commented- Marvin has a page background image, which should be different for RTL themes (it is cut off on the right, while this should be cut off on the left I guess)
Right! I saw the background, but missed the cut off. The attached patch fixes that. The image is on the next comment (although I believe there is nothing wrong with 'cvs diff -aNup').
I bet the Marvin and Chameleon node links borders touching the text directly is also the same Firefox bug
I think that yes. I have checked Opera and Konqueror and they look fine. I don't have access to a stable IE (does anyone? ;) )- so I appreciate if someone can confirm it works for IE. Safari should be identical to Konqueror - but an explicit test would be appreciated as well.
Comment #3
yhager CreditAttribution: yhager commentedflopped image for marvin
Comment #4
Gábor HojtsyOK, let the reviews come!
Comment #5
Gábor HojtsyBy the way, is it right to totally flip that background image? You did not flip the Druplicon in the system... This background is nearly symmetric, so it is not really hurting to flip it, but that area on the top left/right part on the logo should not change sides in the LTR/RTL versions, should it?
Comment #6
z.stolar CreditAttribution: z.stolar commentedChecked both Marvin and Chameleon - nothing to comment, besides the known issues of FF3...
Comment #7
yhager CreditAttribution: yhager commentedAttached is a screenshot of RTL tabs of Marvin under GranParadio alpha4 (latest release of FF3). It seems to really have been fixed :)
Comment #8
yhager CreditAttribution: yhager commentedBy the way, is it right to totally flip that background image? You did not flip the Druplicon in the system... This background is nearly symmetric, so it is not really hurting to flip it, but that area on the top left/right part on the logo should not change sides in the LTR/RTL versions, should it?
I am not sure - I guess it's a matter of taste.. In some cases it would make sense to flip, in others it won't. I think that in this case it's right to flip it.
Comment #9
Gábor HojtsyI got down to my beloved Gimp and done a better cropped image, so the RTL druplicon background will not be flipped but just cropped differently. I think that was the intention here. Committed the CSS changes and the image.
Awaiting a patch and fixes around the remaining pushbutton issues (http://drupal.org/node/148084) as well as RTL-izing Garland and Minnelli.
Comment #10
druvision CreditAttribution: druvision commentedI've installed the FF3 alpha4 and verified: Issues #1-#4 are resolved by FF3.
I couldn't reproduce z.stoler's text-indent issue - it works OK for me.
The only issue I can still find is about admin panels - the right panel only starts when the left panel ends. I can't find why. Seeing clear:none on the clear blocks didn't help (image attached).
Comment #11
druvision CreditAttribution: druvision commentedSorry - the last comment belongs to the pushbutton RTL issue - http://drupal.org/node/148084
Comment #12
(not verified) CreditAttribution: commented