Do not display poll block when no polls are active [#14767]

I use polls infrequently and want them on the sidebar when they are active. But I don't want an inactive poll displayed for weeks or months.

This patch changes the SQL that selects the latest poll to display. It simply adds the requirement that the poll be active.

Comment	File	Size	Author
#6	POLL_HEAD_PATCH.txt	968 bytes	Prometheus6
#3	poll_0.patch	1.19 KB	Prometheus6
#3
	poll.patch	1.14 KB	Prometheus6

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Prometheus6 CreditAttribution: Prometheus6 commented 25 December 2004 at 11:41

Should be vs. CVS instead of 4.5

Comment #2

Dries CreditAttribution: Dries commented 26 December 2004 at 20:02

"JOIN poll p": should be "JOIN {poll} p" or things will break when database prefixing is used.
"on p.nid=n.nid": should be "ON p.nid = n.nid". Use capital letters for SQL keywords, and put spaces around "=".

Other than that, this looks like a bug fix.

Comment #3

Prometheus6 CreditAttribution: Prometheus6 commented 26 December 2004 at 22:28

Category:

feature

» bug

File	Size
poll_0.patch	1.19 KB

Bug fix, yes, but I figured if no one complained in so long it was intentional. Or maybe most people that use polls use them frequently.

Two corrections to formatting, and braces around the table name added.

Comment #4

Dries CreditAttribution: Dries commented 27 December 2004 at 11:50

Comment #5

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 13 March 2005 at 20:16

patch: **** malformed patch at line 12:

Comment #6

Prometheus6 CreditAttribution: Prometheus6 commented 14 March 2005 at 12:43

Priority:

Minor

» Normal

File	Size
POLL_HEAD_PATCH.txt	968 bytes

Comment #7

Steven CreditAttribution: Steven commented 18 March 2005 at 08:56

Your last patch did not include the join. I committed a fixed one to HEAD. I also got rid of the WHERE n.type = "poll" as it is already implicitly taken into account by doing an INNER JOIN on the poll table.