On most pages the login link in colorbox works great. But on pages that have comments enabled and the form inline, it finds the Comment "name" field instead. this is because both the Comment "Name" field and the colorbox login form "username" field have the same id="edit-name".

I've attached a patch that fixes the problem. It simply changes the ID of the login field to "cbox-edit-name", and updates the JS to highlight that field instead. I also updated the id of the password field to "cbox-edit-pass", because it seems like good practice to identify it as colorbox specific as well.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

frjo’s picture

Category: bug » feature
Status: Needs review » Needs work

Please try to upload the patch again. It's just a 0 byte file now.

ohthehugemanatee’s picture

Version: 7.x-1.2 » 7.x-1.3
FileSize
1.13 KB

Well that's unfortunate. Attached a reroll of that original patch against 7.x-1.3 . This time it is definitely NOT just a 0b file. :)

frjo’s picture

Status: Needs work » Fixed

Committed to 7-dev, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.