Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On most pages the login link in colorbox works great. But on pages that have comments enabled and the form inline, it finds the Comment "name" field instead. this is because both the Comment "Name" field and the colorbox login form "username" field have the same id="edit-name".
I've attached a patch that fixes the problem. It simply changes the ID of the login field to "cbox-edit-name", and updates the JS to highlight that field instead. I also updated the id of the password field to "cbox-edit-pass", because it seems like good practice to identify it as colorbox specific as well.
Comment | File | Size | Author |
---|---|---|---|
#2 | 1473624-2-colorbox-login-highlight.patch | 1.13 KB | ohthehugemanatee |
colorbox-login-highlight.patch | 0 bytes | ohthehugemanatee | |
Comments
Comment #1
frjo CreditAttribution: frjo commentedPlease try to upload the patch again. It's just a 0 byte file now.
Comment #2
ohthehugemanatee CreditAttribution: ohthehugemanatee commentedWell that's unfortunate. Attached a reroll of that original patch against 7.x-1.3 . This time it is definitely NOT just a 0b file. :)
Comment #3
frjo CreditAttribution: frjo commentedCommitted to 7-dev, thanks!