Spin-off from #1320648: Meta: start converting existing core classes to PSR-0 [policy, no patch].

CommentFileSizeAuthor
#2 updater-psr0.patch31.02 KBamateescu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Assigned: Unassigned » amateescu
Issue tags: +PSR-0

Started to work on this, but only had a few minutes so it's not in a reviewable state. Will post something tomorrow.

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Assigned: amateescu » Unassigned
Status: Active » Needs review
FileSize
updater-psr0.patch31.02 KB

And here it is :)

Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community

A nice and easy one.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

This looks good. We can iterate on this if necessary. Committed to 8.x. Thanks!

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Title: Convert updater.inc to PSR-0 » [HEAD BROKEN] Convert updater.inc to PSR-0
Status: Fixed » Reviewed & tested by the community

Dries...

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: [HEAD BROKEN] Convert updater.inc to PSR-0 » Convert updater.inc to PSR-0
Status: Reviewed & tested by the community » Fixed

Reverted that commit, trying again. I think I got it http://drupalcode.org/project/drupal.git/commitdiff/368cf30de0237484dd8e...

Is there a better command than git apply that'll catch stuff like this?

rename from core/includes/updater.inc
rename to core/lib/Drupal/Core/Updater/Updater.php
amateescu’s picture

amateescu CreditAttribution: amateescu commented

Mentioned this to @webchick earlier in IRC but maybe it's useful to have it here as well. There's git apply --index that stages everything in a patch, even renamed+changed files.

Automatically closed -- issue fixed for 2 weeks with no activity.