Problem/Motivation

I am expanding on advanced help with the Helpful.module. I want to use the *.help.ini files to add extra parameters to allow advanced help topics to be used in additional ways, but I am unable to get that information because the only hook inside _advanced_help_parse_ini() happens way at the bottom, and the help.ini data is not included.

Proposed resolution

This patch adds 'module' and 'ini' to each cached topic. 'module' is the topic's module, and 'ini' is a direct dump of that topics ini entry, as an array.

Remaining tasks

Not sure.

User interface changes

None.

API changes

This would expand the amount of information available in hook_advanced_help_topic_info_alter()

CommentFileSizeAuthor
#8 advanced_help-ini_data_to_alter-1471092-8.patch671 bytesCauliflower
#6 advanced_help-ini_data_to_alter-1471092-6.patch671 bytesJon Pugh
advanced_help-ini_data_to_alter.patch663 bytesJon Pugh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yktdan’s picture

yktdan CreditAttribution: yktdan commented

+1 on adding this patch. I have long needed to have useful help for our normal users.

hcderaad’s picture

hcderaad CreditAttribution: hcderaad commented

+1

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Needs work

the patch in the original post does not apply

kostajh’s picture

kostajh CreditAttribution: kostajh commented
Status: Needs work » Needs review

It works just fine: patch -p0 < advanced_help-ini_data_to_alter.patch

bleen’s picture

bleen CreditAttribution: bleen commented

This patch was not created with git diff and will not apply with git apply ... This is the accepted practice on d.o.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location Newburgh, NY
CreditAttribution: Jon Pugh commented
FileSize
advanced_help-ini_data_to_alter-1471092-6.patch671 bytes

bleen18 is right, I'm bad at this. The newer recommended patching method is with git, I was using some old techniques...

Here is a patch that applies to 7.x-1.x

Tested with git apply.

bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Reviewed & tested by the community

Looks good ... Thanks for re-rolling

Also, ya know ... feature looks good too. RTBC

Cauliflower’s picture

Cauliflower CreditAttribution: Cauliflower commented
FileSize
advanced_help-ini_data_to_alter-1471092-8.patch671 bytes

Patch based on new dev version.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

This has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.