http://api.drupal.org/api/drupal/core!modules!user!user.pages.inc/functi...

$user is a global variable, while it's not using it as such, bad example.

CommentFileSizeAuthor
#5 user_autocomplete_callback_1454630_5.patch639 bytesmottihoresh
#2 user_autocomplete_callback_1454630_2.patch579 bytesmottihoresh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hefox’s picture

hefox CreditAttribution: hefox commented

drupal_anonymous_user does also, not sure whether to open a separate issue for that.

mottihoresh’s picture

mottihoresh CreditAttribution: mottihoresh commented
Assigned: Unassigned » mottihoresh
Status: Active » Needs review
FileSize
user_autocomplete_callback_1454630_2.patch579 bytes

Status: Needs review » Needs work

The last submitted patch, user_autocomplete_callback_1454630_2.patch, failed testing.

hefox’s picture

hefox CreditAttribution: hefox commented

The for each needs change also

mottihoresh’s picture

mottihoresh CreditAttribution: mottihoresh commented
Status: Needs work » Needs review
FileSize
user_autocomplete_callback_1454630_5.patch639 bytes

I knew i missed something :) Hopefully it will pass this time.

aloyr’s picture

aloyr CreditAttribution: aloyr commented
Status: Needs review » Reviewed & tested by the community

applied change on a fresh drupal 8 git install and the user autocomplete still works for me.

chx’s picture

chx CreditAttribution: chx commented

Very nice catch!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.