I just found out that a domain name, that doesn't match the Fully Qualified Domain Name, is removed and ignored at insert operation in the hook_nodeapi. I think this is not correct because the user is not warned about the error.

I created a small patch that moves the _hosting_valid_fqdn function from the insert to validate, triggering a form_error when the prompted domain name is not valid.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Status: Needs review » Fixed

Reproduced, tested and committed - thanks for your patch! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 274afb2 on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by mig5:
    By Bladeedu: properly validate site aliases on form submission rather...

  • Commit 274afb2 on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by mig5:
    By Bladeedu: properly validate site aliases on form submission rather...