in anticipation of a patch against D6 to move the functionality in http://drupal.org/project/user_status into core, i started looking closely at user_admin_settings(). much to my horror, nearly all of the FAPI arrays in there are on their own giant line, making them harder to read, and harder to modify anything without touching everything. :( i notice some of the arrays in there have the now-standardized format (e.g. the ones regarding signatures), so i know there's hope. ;) here's a simple patch to make at least the email settings more sane. i'd love to see this land quickly, so i can just patch against this better version of user.module when working on moving user_status into here.

thanks,
-derek

p.s. if y'all would like to convert this entire function, just let me know. ;)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

Title: fix code style for user email settings » fix code style for user email settings and unify token list in descriptions
FileSize
7.76 KB

at the risk of feature creep for an otherwise trivial whitespace patch, i just noticed an annoying bug. the '!date' token is only mentioned for the various subject settings, not the bodies, even though it's supported for both. :( plus, it's wasteful and harder to maintain to just duplicate the same list N times. so, i just defined the complete list once and stuffed it into a variable at the top of all the email-related settings, and each description just appends this variable at the end.

webchick’s picture

Status: Needs review » Reviewed & tested by the community

Tested, works, and leaves that old crusty code smelling like new car! RTBC.

Dries’s picture

Committed to CVS HEAD. Thanks.

dww’s picture

Status: Reviewed & tested by the community » Fixed

thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)