If an Aegir site has a large number of clients, then the display of Client Quotas will show only the first 23.

The problem is that the function to theme the list of client quotas (file: hosting_quota.module, function: theme_hosting_quota_admin_list) does not include the "pager" navigation bar at the bottom of the list of the first 23 generated as a result of the pager_query to the database (file: hosting_quota.admin.inc, function: hosting_quota_admin_client_list).

The solution is to add the expression "theme('pager', NULL, 23, 0)" to the end of the output returned from function theme_hosting_quota_admin_list on line # 392 like so:

  return '<p>' . t('Usage information for the last month.') . '</p>' . theme('table', $header, $rows) . theme('pager', NULL, 23, 0);

A useful enhancement would be to replace the occurrence of the literal "23" in both places with a defined constant so that these two routines always remain in step.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jlscott’s picture

Version: 6.x-1.6 » 6.x-1.x-dev
Status: Active » Needs review
FileSize
601 bytes

Patch attached.

jlscott’s picture

The above patch did not make it into release 6.x-1.7, so here is an updated patch.

Steven Jones’s picture

Status: Needs review » Fixed

Awesome, thanks for the patch, applied to 6.x-1.x and 6.x-2.x.

I've cleaned it up further in a follow up commit too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit c07487b on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x authored by jlscott, committed by Steven Jones:
    Issue #1437856 by jlscott: Fixed Display of Client Quota missing pager...
  • Commit 15d5e0e on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1437856 by Steven Jones: Fixed Display of Client Quota missing...

  • Commit c07487b on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x authored by jlscott, committed by Steven Jones:
    Issue #1437856 by jlscott: Fixed Display of Client Quota missing pager...
  • Commit 15d5e0e on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-588728-views-integration, dev-1403208-new_roles, dev-helmo-3.x by Steven Jones:
    Issue #1437856 by Steven Jones: Fixed Display of Client Quota missing...