If an Aegir site has a large number of clients, then the display of Client Quotas will show only the first 23.
The problem is that the function to theme the list of client quotas (file: hosting_quota.module, function: theme_hosting_quota_admin_list) does not include the "pager" navigation bar at the bottom of the list of the first 23 generated as a result of the pager_query to the database (file: hosting_quota.admin.inc, function: hosting_quota_admin_client_list).
The solution is to add the expression "theme('pager', NULL, 23, 0)" to the end of the output returned from function theme_hosting_quota_admin_list on line # 392 like so:
return '<p>' . t('Usage information for the last month.') . '</p>' . theme('table', $header, $rows) . theme('pager', NULL, 23, 0);
A useful enhancement would be to replace the occurrence of the literal "23" in both places with a defined constant so that these two routines always remain in step.
Comment | File | Size | Author |
---|---|---|---|
#2 | hosting_quota-Add-missing-nav-bar-1437856-2.patch | 601 bytes | jlscott |
#1 | hosting_quota-Add-missing-nav-bar-1437856-0.patch | 601 bytes | jlscott |
Comments
Comment #1
jlscott CreditAttribution: jlscott commentedPatch attached.
Comment #2
jlscott CreditAttribution: jlscott commentedThe above patch did not make it into release 6.x-1.7, so here is an updated patch.
Comment #3
Steven Jones CreditAttribution: Steven Jones commentedAwesome, thanks for the patch, applied to 6.x-1.x and 6.x-2.x.
I've cleaned it up further in a follow up commit too.