Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
- Firefox 3.6 will be end-of-lifed on April 24th, 2012 (https://wiki.mozilla.org/Enterprise/Firefox/ExtendedSupport:Proposal)
- less than 5% usage (http://gs.statcounter.com/#browser_version-ww-monthly-201101-201112)
Gain:
- Less testing
- Less coding
Firefox 3.6 issues:
#1218684: Autocomplete popup positioned 2.5em lower in "Seven theme" using Firefox
#1106278: Comment arrow mis-aligned on Firefox 3.6 Mac
#1000106: Firefox/Blocks Bug
#869444: Fix long input form elements with Firefox on Linux (3.6.8 as shipped with Ubuntu Lucid)
....
..
..
Comment | File | Size | Author |
---|---|---|---|
#41 | core-css-drop-ff-vendor-prefix-41.patch | 15 KB | blackra |
#38 | core-css-drop-ff-vendor-prefix-38.patch | 14.59 KB | blackra |
#35 | core-css-drop-ff-vendor-prefix-35.patch | 18.26 KB | blackra |
#29 | reroll-1422614-18.patch | 12.33 KB | droplet |
#27 | reroll-18.patch | 12.33 KB | droplet |
Comments
Comment #1
bleen CreditAttribution: bleen commentedI think droplet has satisfied the same conditions that we tok into account for #1217788: Drop IE7 support in Drupal core and #308865: Drop IE6 support in Drupal core
Lets let testbot take a swing at the patch for the sake of following procedure...
Other than that, RTBC form me
Comment #2
catchComment #4
droplet CreditAttribution: droplet commentedComment #6
droplet CreditAttribution: droplet commentedremove simpletest
Comment #7
droplet CreditAttribution: droplet commented2 stat counters reported 2% of usage only.
http://marketshare.hitslink.com/browser-market-share.aspx?qprid=2&qpcust...
http://gs.statcounter.com/#browser_version-ww-monthly-201112-201205
Comment #8
nod_Apply, looks good to me.
Comment #9
sunI agree.
I'm still using Firefox 3.6, but there's absolutely no reason for actively supporting it in Drupal 8 by 2013. As a user of Firefox 3.6, I'm regularly forced to switch to another browser to see and use modern web pages. However, contrary to that, these removals here will only cause some glitches in styling, but will not break or hinder functionality.
Also, unlike IE, it is much much easier to upgrade to a current version of Firefox 4+.
Comment #10
Dries CreditAttribution: Dries commentedI think this patch needs a quick re-roll. Asking for a re-test.
Comment #11
Dries CreditAttribution: Dries commented#7: drop-ff-vendor-prefix.patch queued for re-testing.
Comment #13
nod_toolbar.css was cleaned from another patch it seems.
Comment #15
nod_#13: core-css-drop-ff-vendor-prefix.patch queued for re-testing.
Comment #17
droplet CreditAttribution: droplet commented#13: core-css-drop-ff-vendor-prefix.patch queued for re-testing.
Comment #18
droplet CreditAttribution: droplet commentedadd back toolbar.css
Comment #19
nod_Need a reroll, couple of conflicts and dashboard has gone away.
Comment #20
blackra CreditAttribution: blackra commented#13: core-css-drop-ff-vendor-prefix.patch queued for re-testing.
Comment #21
blackra CreditAttribution: blackra commentedThat wasn't quite what I intended to happen. I was trying to re-test 18 to find out what the problems were apart from dashboard having gone away.
Comment #22
blackra CreditAttribution: blackra commentedHere is the patch updated to remove the dashboard.css
The primary function of the patch seems to be to remove references to css tags starting with -moz-border-radius . The remaining files containing that tag, but not touched by the patch are as follows:
./core/misc/ui/themes/base/jquery.ui.theme.css
./core/modules/overlay/overlay-child-rtl.css
./core/modules/overlay/overlay-child.css
./core/modules/shortcut/shortcut.theme-rtl.css
./core/modules/shortcut/shortcut.theme.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css.optimized.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css.unoptimized.css
./core/modules/system/system.theme.css
./core/modules/toolbar/toolbar.css
./core/themes/bartik/color/preview.css
./core/themes/bartik/css/style.css
./core/themes/seven/jquery.ui.theme.css
./core/themes/seven/style.css
./core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/Debug/ExceptionHandler.php
Comment #23
blackra CreditAttribution: blackra commentedComment #24
droplet CreditAttribution: droplet commentedSorry. I don't understand why dont touch other modules file.
Comment #25
blackra CreditAttribution: blackra commentedSince those tags weren't touched by the original patch, I wasn't sure whether they were intentionally left out of scope (e.g. because they are required for later versions of Firefox).
I have checked on the Mozilla developer site and they should not be needed for later versions of Firefox. I'll prepare a patch with all of them dealt with.
Comment #26
blackra CreditAttribution: blackra commentedPatch updated to remove all instances of -moz-border-radius
Comment #27
droplet CreditAttribution: droplet commentedReroll #18 without dashboard. checked no other new added styles.
Comment #29
droplet CreditAttribution: droplet commentednaming issue ?
Comment #30
blackra CreditAttribution: blackra commentedWhat was the problem with the 26.patch ?
Comment #31
blackra CreditAttribution: blackra commentedApologies - not trying to take ownership of it again, but please can you take ownership of it if you don't want me working on it.
22 was a straight reroll of 18. 26 was that with the additional modules tackled.
Comment #33
droplet CreditAttribution: droplet commented@rob.black,
you can take over the ownership :)
we don't touch 3rd party scripts
EDIT:
oh. forgot to exclude testcase.
Comment #34
blackra CreditAttribution: blackra commentedI'm new to Drupal. This was marked as a novice issue :-) What counts as 3rd party? Symphony? And what else...?
Comment #35
blackra CreditAttribution: blackra commentedThis is 26 with the Symfony changes removed.
Comment #36
droplet CreditAttribution: droplet commented@rob.black,
- core/vendor
- misc/jquery-*.js
- misc/ui
.....
Comment #37
blackra CreditAttribution: blackra commentedThanks. I will remove jquery but include the theme changes for bartik and seven.
Comment #38
blackra CreditAttribution: blackra commentedThis is 35 re-rolled without jquery (ie only core/modules and core/themes)
Comment #39
blackra CreditAttribution: blackra commentedComment #40
droplet CreditAttribution: droplet commentedGood move @rob.black :)
we also remove -moz-box-shadow.
Comment #41
blackra CreditAttribution: blackra commentedOk. I didn't spot one. I could only find one instance of -moz-box-shadow. Here is an updated version with it removed.
Comment #42
droplet CreditAttribution: droplet commentedComment #43
nod_Welcome and good work rob.black!
Even it it doesn't need to: RTBC seconded :)
Comment #44
webchickNice clean-up! I've always hated those vendor-specific extensions, and given we're now on Firefox 15, it seems appropriate to do this in D8.
Committed and pushed to 8.x. Thanks!