Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bleen’s picture

Status: Active » Needs work

I think droplet has satisfied the same conditions that we tok into account for #1217788: Drop IE7 support in Drupal core and #308865: Drop IE6 support in Drupal core

Lets let testbot take a swing at the patch for the sake of following procedure...

Other than that, RTBC form me

catch’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, drop_ff36.patch, failed testing.

droplet’s picture

Status: Needs work » Needs review
FileSize
13.14 KB

Status: Needs review » Needs work

The last submitted patch, dro_ff36.patch, failed testing.

droplet’s picture

Status: Needs work » Needs review
FileSize
12.56 KB

remove simpletest

droplet’s picture

nod_’s picture

Status: Needs review » Reviewed & tested by the community

Apply, looks good to me.

sun’s picture

I agree.

I'm still using Firefox 3.6, but there's absolutely no reason for actively supporting it in Drupal 8 by 2013. As a user of Firefox 3.6, I'm regularly forced to switch to another browser to see and use modern web pages. However, contrary to that, these removals here will only cause some glitches in styling, but will not break or hinder functionality.

Also, unlike IE, it is much much easier to upgrade to a current version of Firefox 4+.

Dries’s picture

I think this patch needs a quick re-roll. Asking for a re-test.

vortex:drupal-head dries$ git apply ../f.patch --index
error: patch failed: core/modules/toolbar/toolbar.css:39
error: core/modules/toolbar/toolbar.css: patch does not apply
Dries’s picture

#7: drop-ff-vendor-prefix.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drop-ff-vendor-prefix.patch, failed testing.

nod_’s picture

Status: Needs work » Needs review
FileSize
12.31 KB

toolbar.css was cleaned from another patch it seems.

Status: Needs review » Needs work

The last submitted patch, core-css-drop-ff-vendor-prefix.patch, failed testing.

nod_’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, core-css-drop-ff-vendor-prefix.patch, failed testing.

droplet’s picture

Status: Needs work » Needs review
droplet’s picture

add back toolbar.css

nod_’s picture

Status: Needs review » Needs work

Need a reroll, couple of conflicts and dashboard has gone away.

blackra’s picture

Status: Needs work » Needs review
blackra’s picture

Assigned: Unassigned » blackra
Status: Needs review » Needs work

That wasn't quite what I intended to happen. I was trying to re-test 18 to find out what the problems were apart from dashboard having gone away.

blackra’s picture

Here is the patch updated to remove the dashboard.css

The primary function of the patch seems to be to remove references to css tags starting with -moz-border-radius . The remaining files containing that tag, but not touched by the patch are as follows:

./core/misc/ui/themes/base/jquery.ui.theme.css
./core/modules/overlay/overlay-child-rtl.css
./core/modules/overlay/overlay-child.css
./core/modules/shortcut/shortcut.theme-rtl.css
./core/modules/shortcut/shortcut.theme.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css.optimized.css
./core/modules/simpletest/files/css_test_files/css_input_without_import.css.unoptimized.css
./core/modules/system/system.theme.css
./core/modules/toolbar/toolbar.css
./core/themes/bartik/color/preview.css
./core/themes/bartik/css/style.css
./core/themes/seven/jquery.ui.theme.css
./core/themes/seven/style.css
./core/vendor/symfony/http-kernel/Symfony/Component/HttpKernel/Debug/ExceptionHandler.php

blackra’s picture

Status: Needs work » Needs review
droplet’s picture

Status: Needs review » Needs work

Sorry. I don't understand why dont touch other modules file.

blackra’s picture

Since those tags weren't touched by the original patch, I wasn't sure whether they were intentionally left out of scope (e.g. because they are required for later versions of Firefox).

I have checked on the Mozilla developer site and they should not be needed for later versions of Firefox. I'll prepare a patch with all of them dealt with.

blackra’s picture

Status: Needs work » Needs review
FileSize
19.97 KB

Patch updated to remove all instances of -moz-border-radius

droplet’s picture

Assigned: blackra » Unassigned
FileSize
12.33 KB

Reroll #18 without dashboard. checked no other new added styles.

Status: Needs review » Needs work

The last submitted patch, reroll-#18.patch, failed testing.

droplet’s picture

Status: Needs work » Needs review
FileSize
12.33 KB

naming issue ?

blackra’s picture

Assigned: Unassigned » blackra

What was the problem with the 26.patch ?

blackra’s picture

Assigned: blackra » Unassigned

Apologies - not trying to take ownership of it again, but please can you take ownership of it if you don't want me working on it.

22 was a straight reroll of 18. 26 was that with the additional modules tackled.

Status: Needs review » Needs work

The last submitted patch, reroll-1422614-18.patch, failed testing.

droplet’s picture

Status: Needs work » Needs review

@rob.black,

you can take over the ownership :)
we don't touch 3rd party scripts

EDIT:
oh. forgot to exclude testcase.

blackra’s picture

I'm new to Drupal. This was marked as a novice issue :-) What counts as 3rd party? Symphony? And what else...?

blackra’s picture

This is 26 with the Symfony changes removed.

droplet’s picture

@rob.black,

- core/vendor
- misc/jquery-*.js
- misc/ui
.....

blackra’s picture

Assigned: Unassigned » blackra

Thanks. I will remove jquery but include the theme changes for bartik and seven.

blackra’s picture

Status: Needs review » Needs work
FileSize
14.59 KB

This is 35 re-rolled without jquery (ie only core/modules and core/themes)

blackra’s picture

Status: Needs work » Needs review
droplet’s picture

Good move @rob.black :)

we also remove -moz-box-shadow.

blackra’s picture

Ok. I didn't spot one. I could only find one instance of -moz-box-shadow. Here is an updated version with it removed.

droplet’s picture

Status: Needs review » Reviewed & tested by the community
nod_’s picture

Welcome and good work rob.black!

Even it it doesn't need to: RTBC seconded :)

webchick’s picture

Component: base system » markup
Status: Reviewed & tested by the community » Fixed

Nice clean-up! I've always hated those vendor-specific extensions, and given we're now on Firefox 15, it seems appropriate to do this in D8.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.