Port Rules integration to 7.x-2.x

Wondering if Rules integration is in the dev release. Right now looks like the rules for OG don't work, for example "OG group members" returns empty values.

I have upload a patch at http://drupal.org/node/1502956 ,
Which fixed all the issues of rules integration that i could find.
I upload the latest patch at here.

Using db_select is much easier than entityFieldQuery at here.

If we use entityFieldQuery,
1,then we get the membership ids first,
2,we need write a foreach function,
3,then we need load all the membership objects through ids,
4,then get the etid.

It is much complex than using db_select.
Instead of using db_select,which could get all current members in one step. we write less code, and the speed is quick than using entityFieldQuery.

There are a lot place in drupal core, which could use entityFieldQuery also coudl use db_select. at most case, they use
db_select instead of entityFieldQuery. for example

/**
 * Implements hook_user_cancel().
 */
function node_user_cancel($edit, $account, $method) {
  switch ($method) {
    case 'user_cancel_block_unpublish':
      // Unpublish nodes (current revisions).
      module_load_include('inc', 'node', 'node.admin');
      $nodes = db_select('node', 'n')
        ->fields('n', array('nid'))
        ->condition('uid', $account->uid)
        ->execute()
        ->fetchCol();
      node_mass_update($nodes, array('status' => 0));
      break;

At here using entityFieldQuery also works, but if we use db_select, it is much short, concise, quick.

So I think we do not need to use entityFieldQuery instead of db_select at here.

here is the latest patch, fixed "Start with capital, and finish with dot.", and "Remove space.".

I tested the patch last week, and it does work fairly well for the standard use cases. The rules are now restricted to group nodes, but could possibly be used for other group entities like user or anything that has a uid column.

I played around with the rules integration some more and was able to come up with more complex things.

Is there a base set of rules functionality we need to test manually for this task?

Changing status to run latest patch through automated tests (hopefully).

I have spend my three days vocation to port it to 2.x. and did not earn 1 commit to OG.

I think the patch is a good start, but we will only find out the more edge cases in further issues.

Thanks Amitaibu, i earn another commit to OG. I have 2 commits now.

I saw that this was committed over a month ago, but still not a part of alpha-3? I see it in the patch notes, but I don't see any triggers for OG. Have I configured something incorrectly? Never mind, I was confusing D7's triggers with Rules but then I finally sobered up. :)