The submit handler for the blocks admin gives an E_ALL notice for each block when throttle.module is disabled. Attached one-liner fixes it using !empty().

CommentFileSizeAuthor
#2 blocks_nothrottle_0.patch1.21 KBChrisKennedy
blocks_nothrottle.patch1.21 KBChrisKennedy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Needs work

throttle is an integer and we're passing in the empty string? Might be better to explicitly pass it 1 and 0?

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented
Status: Needs work » Needs review
FileSize
blocks_nothrottle_0.patch1.21 KB

Ah sorry - rerolled. I changed it from !empty to isset also, which I think is clearer.

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented

http://drupal.org/node/143384 marked as a duplicate, same patch as #3.

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented

Oops, I meant #2.

rstamm’s picture

rstamm CreditAttribution: rstamm commented
Status: Needs review » Reviewed & tested by the community

Patch #2 works as advertised.

drewish’s picture

drewish CreditAttribution: drewish commented

yeah +1, i wrote the same patch.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks Chris.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented

Committed to 5.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)