When changing color information on Garland, upon hitting submit I see these notices:

# notice: Undefined variable: file in /var/www/head/modules/color/color.module on line 224.
# notice: Undefined index: op in /var/www/head/modules/color/color.module on line 230.
# notice: Undefined variable: numerator in /var/www/head/modules/color/color.module on line 445.
# notice: Undefined variable: denominator in /var/www/head/modules/color/color.module on line 446.
# notice: Undefined variable: out in /var/www/head/modules/color/color.module on line 521.
# notice: Undefined variable: numerator in /var/www/head/modules/color/color.module on line 445.
# notice: Undefined variable: denominator in /var/www/head/modules/color/color.module on line 446.

The last 3 are repeated at least 20 times.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kaerast’s picture

FileSize
682 bytes

# notice: Undefined variable: file in /var/www/head/modules/color/color.module on line 224.

is fixed with the attached patch - it was a simple curly bracket in the wrong place. I don't know how to fix the other errors though.

rstamm’s picture

Title: color.module throws a lot of notice errors » E_ALL: color.module throws a lot of notice errors
Status: Active » Needs review
FileSize
1.34 KB

Cannot confirm

# notice: Undefined variable: file in /var/www/head/modules/color/color.module on line 224.

but the rest will be fixed by the patch.

webchick’s picture

Status: Needs review » Needs work

Patch no longer applies. http://drupal.org/node/163080 is a duplicate with some very nice information on how to reproduce.

rstamm’s picture

Patch rerolled.

rstamm’s picture

Status: Needs work » Needs review
Gábor Hojtsy’s picture

Status: Needs review » Fixed

Looks fine, thanks, committed!

Anonymous’s picture

Status: Fixed » Closed (fixed)