This comes up on trying to upgrade to drupal 6.x-dev.

PHP Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of [runtime function name](). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file. in C:\Inetpub\wwwroot\drupal6\update.php on line 292 PHP Warning: Unknown column 'serialized' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache WHERE cid = 'variables' in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Unknown column 'serialized' in 'field list' query: UPDATE cache SET data = 'a:141:{s:13:\"theme_default\";s:4:\"yaml\";s:13:\"filter_html_1\";i:1;s:18:\"node_options_forum\";a:1:{i:0;s:6:\"status\";}s:17:\"menu_primary_menu\";s:1:\"2\";s:19:\"menu_secondary_menu\";s:2:\"56\";s:19:\"file_directory_temp\";s:9:\"../phptmp\";s:9:\"site_mail\";s:19:\"example@example.com\";s:11:\"site_slogan\";s:0:\"\";s:12:\"site_mission\";s:0:\"\";s:9:\"anonymous\";s:9:\"Anonymous\";s:14:\"site_frontpage\";s:4:\"node\";s:9:\"clean_url\";s:1:\"1\";s:8:\"site_403\";s:0:\"\";s:8:\"site_404\";s:0:\"\";s:11:\"error_level\";s:1:\"0\";s:14:\"cache_lifetime\";s:4:\"3600\";s:5:\"cache\";s:1:\"1 in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Table 'drupal6.cache_page' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_page WHERE cid = 'http://localhost/drupal6/update.php?' in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Unknown column 'language' in 'where clause' query: SELECT src FROM url_alias WHERE dst = 'node' AND language IN('en', '') ORDER BY language DESC in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151
CommentFileSizeAuthor
#4 update.php__2.patch606 bytesyched
#2 update.php__1.patch623 bytesyched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass’s picture

hass CreditAttribution: hass commented

and "Run updates" gave me this:

    * notice: Undefined property: stdClass::$sid in C:\Inetpub\wwwroot\drupal6\includes\form.inc on line 1872.
    * user warning: Unknown column 'fit' in 'order clause' query: SELECT * FROM menu WHERE path IN ('node') ORDER BY fit DESC LIMIT 0, 1 in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151.
    * notice: Trying to get property of non-object in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * warning: array_reverse() [function.array-reverse]: The argument should be an array in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * warning: Invalid argument supplied for foreach() in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * notice: Undefined property: stdClass::$sid in C:\Inetpub\wwwroot\drupal6\includes\batch.inc on line 15.

and the progress bar is loading and loading and loading - and never ends.

yched’s picture

yched CreditAttribution: yched commented
FileSize
update.php__1.patch623 bytes

Attached patch should fix the 'Call-time pass-by-reference has been deprecated' warning. It's from the 'batch' patch in http://drupal.org/node/127539. I think I spotted that at some point, and then forgot...

For the other warnings : what were you upgrading from ? D5, or a previous D6 state ?
I'm not sure the menu changes in D6 core come with a neat upgrade path - I think I had to manually update the tables a few times.

This being said, there is supposedly an error catching mechanism in the update progress bar that should prevent it from running on and on, but I was having a hard time trying to find an actual case to test, so I'd be interested in knowing where you upgraded from.

hass’s picture

hass CreditAttribution: hass commented

i tried upgrading from prior D6

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review
FileSize
update.php__2.patch606 bytes

'Call-time pass-by-reference' warning : scrap my previous patch - the reference is not needed in fact, attached patch simply wipes it.

@haas : can you tell (even approximatively) what was the date of your previous D6 state ?

hass’s picture

hass CreditAttribution: hass commented

difficult... 2 weeks? not sure

hass’s picture

hass CreditAttribution: hass commented

if i take my 5.1 backup an try to update with D6-dev (04.05) i'v got the same errors...

After applying your patch i get this errors (D5.1 -> D6):

PHP Warning: Unknown column 'serialized' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache WHERE cid = 'variables' in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Unknown column 'serialized' in 'field list' query: UPDATE cache SET data = 'a:176:{s:13:\"theme_default\";s:4:\"yaml\";s:13:\"filter_html_1\";i:1;s:18:\"node_options_forum\";a:1:{i:0;s:6:\"status\";}s:19:\"file_directory_temp\";s:9:\"../phptmp\";s:9:\"site_name\";s:49:\"YAML für Drupal - Yet Another Multicolumn Layout\";s:9:\"site_mail\";s:20:\"example@example.com\";s:11:\"site_slogan\";s:0:\"\";s:12:\"site_mission\";s:0:\"\";s:9:\"anonymous\";s:9:\"Anonymous\";s:14:\"site_frontpage\";s:4:\"node\";s:9:\"clean_url\";s:1:\"1\";s:8:\"site_403\";s:0:\"\";s:8:\"site_404\";s:0:\"\";s:11:\"error_level\";s:1:\"0\";s:14:\"cache_lifetime\";s:5:\"10800\";s:5:\"cache\";s:1:\"1\";s:19:\" in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Unknown column 'serialized' in 'field list' query: SELECT data, created, headers, expire, serialized FROM cache_page WHERE cid = 'http://localhost/drupal6/update.php?' in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151 PHP Warning: Unknown column 'language' in 'where clause' query: SELECT src FROM url_alias WHERE dst = 'node' AND language IN('en', '') ORDER BY language DESC in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151
hass’s picture

hass CreditAttribution: hass commented

and not to miss, this:

    * notice: Undefined property: stdClass::$sid in C:\Inetpub\wwwroot\drupal6\includes\form.inc on line 1872.
    * user warning: Unknown column 'fit' in 'order clause' query: SELECT * FROM menu WHERE path IN ('node') ORDER BY fit DESC LIMIT 0, 1 in C:\Inetpub\wwwroot\drupal6\includes\database.mysqli.inc on line 151.
    * notice: Trying to get property of non-object in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * warning: array_reverse() [function.array-reverse]: The argument should be an array in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * warning: Invalid argument supplied for foreach() in C:\Inetpub\wwwroot\drupal6\includes\menu.inc on line 1032.
    * notice: Undefined property: stdClass::$sid in C:\Inetpub\wwwroot\drupal6\includes\batch.inc on line 15.
hass’s picture

hass CreditAttribution: hass commented

Big mistake... someone able to edit my first posting and remove my email from the error, please?!!!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Postponed (maintainer needs more info)

@hass: Ok, removed the email address. Please take a bit more attention to what you post next time.

@yched, comitted the call-time pass by reference fix. The other problems are seem to be appearing in menu.inc

@yched, maybe you can look into fixing the "Undefined property: stdClass::$sid" notices noted by hass. These seem to come from update.php supporting to run the update without a user session (without a user logged in), as long as the update.php code is edited to allow update without authentication.

yched’s picture

yched CreditAttribution: yched commented

batches without user session : yes, this is a problem with current batch API.
A quick hotfix could be to remove that $user->sid security check for now.
It should probably be handled differently, something more in the line of FAPI 'tokens'.

I'll try to see this with Eaton in the FAPI3 patch (which is currently in a 'batch adaptation' phase)

chx’s picture

chx CreditAttribution: chx commented
Status: Postponed (maintainer needs more info) » Fixed
yched’s picture

yched CreditAttribution: yched commented

True, this has been fixed since then.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)