Regression: Overview screen is unusable for freetagging [#141470]

Comment	File	Size	Author
#9	taxo_6.patch	3.25 KB	bdragon

#8	taxo_5.patch	3.15 KB	bdragon

#4	taxo_4.patch	2.97 KB	chx

	taxo_3.patch	2.8 KB	chx

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 7 May 2007 at 08:58

Status:

Reviewed & tested by the community

» Needs work

The code that is there already looks a bit shaky. I think it would be best to clean it out rather than add another layer. Here is what I see:

* A couple lines commented FIXME that are modifying the pager's globals.
* A conditionally-inserted pager inside the table, which should always be inserted, right after the table.

It looks like the code is already trying to do the right thing with pagers, but stumbling upon not having a real query, which pagers tend to like.

Log in or register to post comments

Comment #2

chx CreditAttribution: chx commented 7 May 2007 at 09:11

Status:

Needs work

» Reviewed & tested by the community

The tree-displaying code can't really use pager_query without adding some serious amounts of code (you would need to keep some form of materialized path stored, maintained etc) and I have not even touched that. My code just adds a few lines for flat displays which can and should use flat display.

Log in or register to post comments

Comment #3

drumm

he/him

NY, US

CreditAttribution: drumm commented 22 May 2007 at 05:35

Status:

Reviewed & tested by the community

» Needs work

Okay, we can go with this general design then. However, lets clean up the code style a little bit. Here are some ideas-

* Flip around the if statement to remove the '!'.
* Use 'h.parent' instead of 'parent'.
* Why are we getting both 't.tid' and 't.*'?
* 'text/'. $variable instead of "text/$variable".

Log in or register to post comments

Comment #4

chx CreditAttribution: chx commented 17 June 2007 at 01:04

Status:

Needs work

» Reviewed & tested by the community

File	Size
taxo_4.patch	2.97 KB

I did the first three action points and even added more comments (Dries always wants more comments, so I thought why not :) ). But the fourth action point I am not doing, see almost the end of http://phplens.com/lens/php-book/optimizing-debugging-php.php (or just search on php 4.3 and see what it has to say). I find this version much more readable.