Bug in taxonomy_node_get_terms(): the index key is not always respected [#141204]

Currently, taxnomy_node_get_terms() only respects the given key the first time it is called for a specific node. The second time, no matter what key is given, it will use the same key. This is because the static variable in which it is cached, is only cached by nid, and not by the key.

Patch is attached. It has a simple and clean solution IMO.

Comment	File	Size	Author
#4	taxonomy_node_get_terms_key_0.patch	1.04 KB	Wim Leers
#4
#3	taxonomy_node_get_terms_key_HEAD_0.patch	1.08 KB	Wim Leers
#3
#2	taxonomy_node_get_terms_key_HEAD.patch	1.06 KB	Wim Leers
#2
	taxonomy_node_get_terms_key.patch	1.02 KB	Wim Leers

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 3 May 2007 at 22:22

Version:	5.1	» 6.x-dev
Status:	Needs review	» Reviewed & tested by the community

Nice catch but we usually fix HEAD first and port down.

Comment #2

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 3 May 2007 at 22:35

Title:

Bug in taxonomy_node_get_terms: the index key is not always respected

» Bug in taxonomy_node_get_terms(): the index key is not always respected

File	Size
taxonomy_node_get_terms_key_HEAD.patch	1.06 KB

In my excitement of finding my very first Drupal Core bug, I forgot to check HEAD first :P But since it's so trivial, here's the patch for HEAD already. Now you can commit both :)