A comment on the topic of not giving sessions to UAs that don't accept cookies in sessions.inc includes the phrase:

"This improves speed up queries"

- which is incorrect grammatically and also practically (it reduces the number of queries, which lowers server load - it doesn't directly improve the speed of any single query).

The attached patch rewrites this comment to this effect.

CommentFileSizeAuthor
sessions_comment.patch1.19 KBOwen Barton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Owen Barton’s picture

Owen Barton CreditAttribution: Owen Barton commented
Title: Fix typo » Fix incoherent comment in session.inc

Umm - fixing title!

Dries’s picture

Dries CreditAttribution: Dries commented
Version: 6.x-dev » 5.x-dev
Status: Needs review » Reviewed & tested by the community

Committed to CVS HEAD. Good catch.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Committed to 5.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)