Impossible to install Drupal in a non-English language when following the provided instructions

Yes, this functionality has a component of development on localize.drupal.org to introduce the public download of these files. Currently, these files are only possible to generate on the admin side of localize.drupal.org (and are committed to drupal.org git to be packaged with the l10n_install profile). Distro type projects should get install.po file downloads and the UI for these downloads should display the files. This does need some development on that side and is tracked in #1392330: Add installer .po file downloads for distro type projects.

Until that is done, the best instructions we could provide is to either symlink the core .po file also as installer.$langcode.po for the langcode in question or copy the file under that name. We can get in a quirky temporary install instruction if that looks like a good idea. I thought wordsmithing on interim, temporary solutions is a waste of time.

Tagging for D8MI.

Could we possibly add a change notice somewhere with the interim instructions, just to have somewhere to point to other than this issue?

I'm tempted to downgrade this and tag it with 'revisit before release' - we should ensure localize.drupal.org has compatible files before 8.0 ships, but I don't think there's much that's actionable in core to either make that happen or work around it if it doesn't.

Tempted enough I'm going to do that for now.

Heh, I had the same worry, so I opened #1393358: [META-12] Review 'revisit before release candidate' tag.

Critical/postponed might work, not sure whether 'normal' or 'postponed' makes it more or less hidden really (the less hidden the better IMO).

Tagging for base language system.

Tagging for the sprint, I hope to see this on D8.

Marked #1733766: Localized installation instructions are not self-explanatory as duplicate.

Re-uploading @penyaskito's patch for review.

I think a better short term solution might be to change the install.$langcode.po pattern to drupal-$version.$langcode.po pattern, where we don't check the version at all, just the langcode, so whatever version file we find there, we take that. Something like the attached (not tested). This is still temporary too, but avoids user work while we can just automate this.

The assertions on the test needs to be changed. This is well test-covered btw :)

I've just tested this and it's working fine.

Unintentional status change from 'needs review' - switching back.

So in the tests, the naming of the files are significant, because we are looking at whether the concerete files were found. Should rename the test installer files as well.

Ran the test locally as well, came back green and worked fine!

updating status~

That sounds like a great fix to me. :)

Committed and pushed to 8.x. Thanks!

There are still some issues in the remit of "Impossible to install Drupal in a non-English language when following the provided instructions":

1) It would be nice to just allow the file to be named (anything optional).langcode.po , i.e de.po or whatever.de.po Currently finding that the drupal-7.15.de.po file I downloaded did not get recognized if renamed to de.po, as has always worked in previous versions of Drupal.

2) In core/profiles/standard/translations, the README.txt file reads:

This directory should be used to place downloaded translations
for installing Drupal core.

Putting a .po file (however it's named) in this location does NOT work.

3) The directions say to put the translation file in the sites/default/files/translations directory, which does not exist. Once created, files named according to the naming pattern (drupal-7.15.de.po) will be recognized there. Ideally, we should not have the core/profiles/standard/translations directory at all and perhaps as an interim solution, at least the README file should direct users to the correct location (sites/default/files/translations).

4) Assuming you have a second language enabled and install in it, the selector for that language is a bit odd:

Before adding a non-English translation file (normal):

After adding a translation file:

5) Finally (and I think I'll report this as a separate issue), if you install in one non-English language and make it your default, if you attempt to access /en/ paths, you may find that some of the interface text is still translated to the default (e.g. German) language.

I'm gonna test that.

1/ The attached patch should fix it.
2 & 3/ The documentation hasn't been updated, the installer isn't looking in the installation profiles anymore we should no longer have those directories either the attached patch is removing them.
4/ I agree that the multiselect is weird and the dropdown is a pattern that makes more sense, we were using the size attribute to limit the size of the multiselect in case we had a ton of available languages, i don't think that for most of the users they will have more than 5 items so the dropdown is more usable in that situation.

Please test the patch :)

Sorry for the double post.

Okay, 1-2-3-4 is solved by the patch. But 5 needs to be addressed, too: I did have the same bug that was mentioned in #22, but when I changed to the non-English language I have installed with (Hungarian in my case) I could find English strings appearing every here and there that _are_ included in the .po file with proper translations.

Anyway, I don't know what's the proper step next, thus I don't touch the issue status.

Patch looks good, but I'm not sure about the regex change in install_find_translation_files()... what happens if the user puts other translation files into the same folder? (e.g. for old versions of core, contrib modules etc.).

The issue about translated text on english pages (en/ path) has also come up in #1738330-38: Confusing Language negotiation when accessing / and I also think will need its own issue.

Reverting unintentional status change.

+++ b/core/includes/install.core.inc
@@ -1211,7 +1211,7 @@ function install_find_translations() {
-  $files = file_scan_directory($directory, '!drupal-\d+\.\d+\.' . (!empty($langcode) ? preg_quote($langcode, '!') : '[^\.]+') . '\.po$!', array('recurse' => FALSE));
+  $files = file_scan_directory($directory, '!(drupal-\d+\.\d+\.)?' . (!empty($langcode) ? preg_quote($langcode, '!') : '[^\.]+') . '\.po$!', array('recurse' => FALSE));

Reverting this changes then i give false language option during installation if the user put module translation into this folder. Adding more details to INSTALL.txt to make sure the user uses the correct naming schema.

Ooobs, let's try that one more time without the stray line.

Confirmed that everything covered here is now working, as expected. Part #5, I think, is unrelated enough it should have its own issue: #1741170: Installing with non-English language results in mix of languages in some part of the UI

Looking good! :-)

Improved wording in INSTALL.txt

I was expecting #5 to be in a dedicated issue yes, the new wording looks great to me.

Looks good to me as well.

Just made a couple of small edits to the text in INSTALL.txt w/ the help of Gábor and Julien to make it more clear what the "x"s in that string meant:

     If the directory doesn't exist, you should create it. Make sure your file
     is named drupal-VERSION.LANGCODE.po (for example, the German
     translation for Drupal 8.0 should be named drupal-8.0.de.po).

Committed and pushed to 8.x. Thanks!

The changes documented here happened earlier so no changelog needed. Fully done for D8 and off the sprint. (Adding automated .po downloads will necessitate updating this instruction again, but that is a different issue).

A fix has been suggested and applied after the revisit tag was added, so the tag is no longer needed.