Found out when working on the field info cache optimization in #1040790: _field_info_collate_fields() memory usage :
EntityFieldQueryTestCase::setup() does not properly declare the bundles it adds on test field types.
In order to have the bundles appear in entity_get_info(), and in the current state of the field_test.module, the function to call is field_test_create_bundle() - which takes care of calling field_attach_create_bundle().
Not critical for the current state of Entity API / Field API, but working on bundles that are not listed in entity_get_info() is not recommended.
Given the strictly test-internal nature of this, and probable low amount of reviewers for that, I'll be bold and push this directly to RTBC. Feel free to scold :-)
Comment | File | Size | Author |
---|---|---|---|
#3 | EFQtests-bundles-d7-1391426-3.patch | 1.95 KB | yched |
EFQtests-bundles.patch | 1.97 KB | yched | |
Comments
Comment #1
tim.plunkettWhile I wish I could bounce this back to needs work just to make a point, this makes perfect sense, and I would call this RTHC.
Comment #2
catchMakes sense and I'll accept the post-facto RTBC.
Committed/pushed to 8.x, this will need backport.
Comment #3
yched CreditAttribution: yched commentedD7 patch.
Comment #4
webchickCommitted and pushed to 7.x. Thanks!