I am working on a module that uses hook_js_alter() to replace the core JS with minified alternatives (of the correct version).

Minifying ajax.js, however, breaks it due to the lack of a semi-colon at the end of the Drupal.ajax.prototype.beforeSubmit function.

Attached is a patch to add the required semi-colon and allow the file to be successfully minified.

CommentFileSizeAuthor
#3 ajax_minified-1387098.patch481 bytesLSU_JBob
ajaxjs_allow_minification.patch461 bytesnburles
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

thnx!

droplet’s picture

droplet CreditAttribution: droplet commented
Version: 7.x-dev » 8.x-dev
Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +Needs backport to D7
LSU_JBob’s picture

LSU_JBob CreditAttribution: LSU_JBob commented
FileSize
ajax_minified-1387098.patch481 bytes

rerolled for 8.x-dev, picked up from the novice queue

LSU_JBob’s picture

LSU_JBob CreditAttribution: LSU_JBob commented
Status: Needs work » Needs review
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
CreditAttribution: oriol_e9g commented
Status: Needs review » Reviewed & tested by the community

It's good!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Easy one. Committed to 8.x and backported to 7.x. Thanks all.

Automatically closed -- issue fixed for 2 weeks with no activity.