Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
hook_update_N documentation has two dead links on Drupal.org:
- http://drupal.org/node/93999 (Overview of contributions branches and tags)
- http://drupal.org/handbook/cvs/releases
This patch replaces them with the link with information needed.
Comment | File | Size | Author |
---|---|---|---|
#13 | drupal-1377544-13.patch | 1.58 KB | kotnik |
#11 | drupal-1377544-11.patch | 3.14 KB | kotnik |
#7 | drupal-1377544-7.patch | 1.92 KB | kotnik |
#5 | drupal-1377544-5.patch | 1.92 KB | kotnik |
#3 | drupal-1377544-3.patch | 1.76 KB | kotnik |
Comments
Comment #1
jhodgdonGood catch, thanks!
I think we should also remove the link to http://drupal.org/documentation/version-info -- it doesn't seem at all relevant. The Git page you referenced has all the necessary information I think?
And maybe if this is the only information we're including about releases and numbers, that link should be moved up to the paragraph that currently says:
A good rule of thumb is to remove updates older than two major releases of Drupal. See hook_update_last_removed() to notify Drupal about the removals.
Comment #2
kotnik CreditAttribution: kotnik commentedYes you're quite right, http://drupal.org/documentation/version-info does not give useful information. I think that Git page does.
I'll send updated patch.
Comment #3
kotnik CreditAttribution: kotnik commentedHere's re-roll that removes all obsolete links, and moves paragraph up as you've suggested.
Comment #4
sven.lauer CreditAttribution: sven.lauer commentedI think what @jhodgdon meant was to integrate the link in the referenced paragraph. At least that makes sense to me. And also: Given that the list now only contains one single item, it should not be a list, but should be integrated in one sentence ("For further information about releases and release numbers see @link ...").
Comment #5
kotnik CreditAttribution: kotnik commentedGot it, here's corrected patch.
Comment #6
jhodgdonThat's good, just don't put the link text in parentheses:
+ * @link http://drupal.org/node/711070 (Maintaining a drupal.org project with Git) @endlink
(sorry, I missed that in your original patch)
See
http://drupal.org/node/1354#links
Comment #7
kotnik CreditAttribution: kotnik commentedSorry I missed that as well. Patch attached.
Comment #8
jhodgdonThat looks good! Thanks. And by the way, set an issue status to "needs review" to trigger the testing bot. :)
Comment #9
kotnik CreditAttribution: kotnik commentedThanks, and I'll try to be more careful the next time. :)
Comment #10
sunExceeds 80 chars.
Note: Does not apply to the @link line.
Comment #11
kotnik CreditAttribution: kotnik commentedFixed.
Also fixed other lines in the same file that exceeded 80 chars limit.
Comment #12
jhodgdonI think it's best to limit this patch to fixing the issue reported and the text right around there. We're cleaning up general documentation issues (such as 80-character lines) in
#1310084: [meta] API documentation cleanup sprint
if you would like to help with that effort. Thanks!
Comment #13
kotnik CreditAttribution: kotnik commentedSure.
Patch attached.
Comment #14
jhodgdonThanks! I think this is ready to go now.
Comment #15
Dries CreditAttribution: Dries commentedCommitted to 8.x and backported to 7.x.
Comment #16.0
(not verified) CreditAttribution: commentedTypo fix