We can use provision_nginx_vhost_config to add extra config to virtual hosts, but anything added here only gets added to the main vhost, and not to the ssl host. Extra config should be added to both ssl and non-ssl hosts. The only difference between the ssl and non-sl hosts should be the presence or absence of ssl.

CommentFileSizeAuthor
#2 1369608.2-provision-nginx-ssl-extra-config.patch591 bytesmrfelton
#1 1369608-provision-nginx-ssl-extra-config.patch523 bytesmrfelton
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Status: Active » Needs review
FileSize
1369608-provision-nginx-ssl-extra-config.patch523 bytes
mrfelton’s picture

mrfelton CreditAttribution: mrfelton commented
Version: 6.x-1.x-dev » 6.x-2.x-dev
FileSize
1369608.2-provision-nginx-ssl-extra-config.patch591 bytes

Updated patch for 2.x

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Needs review » Reviewed & tested by the community

Oh, we already included this in BOA and I forgot to mark this as reviewed, sorry!

Please commit this :)

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a265e19 on 6.x-2.x, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by mig5: 
    By mrfelton: include extra_config in Nginx SSL vhost. Fixes #1369608
  • Commit cc2f00f on 6.x-1.x, dev-drupal-8, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by mig5:
    By mrfelton: include extra_config in Nginx SSL vhost. Fixes #1369608