Fixes for PHP warnings [#1350416]

I am a new user of this module and am initially impressed with its capabilities. With all new modules, I tend to run them for a bit with the highest level of error/warning/notice checking enabled. On one of my websites, I was getting complaints in the watchdog file about headers_list and undefined index in $menu_args. The attached patch fixed the two issues for me.

Comment	File	Size	Author
#1	fixes_for_php_warnings-1350416-1.patch	1.15 KB	Lars Toomre
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Lars Toomre CreditAttribution: Lars Toomre commented 23 November 2011 at 13:18

File	Size
fixes_for_php_warnings-1350416-1.patch	1.15 KB

Attaching the patch file now that there is an issue number...

Comment #2

Lars Toomre CreditAttribution: Lars Toomre commented 23 November 2011 at 14:50

Reviewing another of my sites, I observe that there are other PHP warnings that need to be corrected in the D6 boost module. A more complete patch will be forthcoming in the next few days.

Comment #3

bgm CreditAttribution: bgm commented 14 December 2011 at 18:15

Status:

Active

» Fixed

Thanks for the patch. Committed to 6.x-1.x.

Comment #4

Lars Toomre CreditAttribution: Lars Toomre commented 14 December 2011 at 23:56

@bgm - You are welcome for the fix to those PHP warnings.

The Drupal 6 version of this module currently generates many warnings for me when run under E_STRICT PHP mode. Would you also like patches that address issues like "E_STRICT: Only variables should be passed by reference in 'sites/all/modules/boost/boost.module'". I am slowly modifying my version to reduce such trace log messages due to the boost module.