default display being hidden makes it possible to be unable to save a view with validation errors

I had a similar issue since updating. I solved this problem by going to the field that was giving the issue on a display that I knew would validate and changing "Configure filter criterion for:" and changing it to all displays. Then I went back and made sure the other displays were overriding that to show what they needed to and this solved the problem.

Ugh. That's a case where you need to go into the Settings and check the box that makes the master (formerly default) display always appear.

In my opinion, anyone who actually uses Views a lot should do this regardless. The master display is a very important piece of information.

I would have said the same thing than merlinofchaos. Go in the Settings and make the master display always appear.

The patch from http://drupal.org/node/1343888#comment-5267556 would at least allow to access the default display directly via url.

One suggestion:

* Make the default tab available via url
* When the validation fails on a display always show this display and mark the background of the tab as red.

This would allow people to fix the error, some oppinions?

Let's mark it as major as there is a temporary workaround and people can use views though.
Sure this should be fixed.

Okay here is a first approach, some critics are welcomed, the current code does add foo all the time to test it.

Maybe someone could come up with better colors.
There is also a color needed for opened tab has errors.

The patch seems to cause the master display to be visible at all times, even with the setting turned off.

Yeah there was a reason it was set to active ...

If this is just for the tab, would using #views-display-menu-tabs be better?

Well the other css use the same selector

Do you agree in general with the approach?

See #1419978: Allow saving of a view when there are validation errors on the master display (comment 4) for steps to reproduce a recoverable validation error in this context.

+++ b/includes/view.incundefined
@@ -1889,9 +1897,13 @@ class view extends views_db_object {
+    $this->display_errors['default'] = TRUE;

Just wondering, maybe you overlooked this debugging line?

So remove the debugging and update status.

This patch definitive needs a review by someone else.

The patch works as it should; the logic is fine and classes are added to the markup correctly. I think it's just the css that is the problem :) As meantioned in IRC, I think it should be a red outline and not a background color. How about this?

Let's get it in

Thanks for the visual improvement and testing!

Here is one for 8.x

They look identical!

Let's get it in!