The attached patch has 173 minor coding standard fixes found using the coder. Most changes are due to the string concatentation rules, but there are a few others. I tried to not modify more than was needed, but some double checking is definitely in order.

CommentFileSizeAuthor
#1 core-style_0.patch60.27 KBchx
core-style.patch68.33 KBdouggreen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community
FileSize
core-style_0.patch60.27 KB

Drupal plumbing season!! Nice job man. Just reading the patch made me tired :P I caught a miniscule error, namely you included E_ALL ^ E_NOTICE inside the patch. Removed that, rerolled, RTBC'd. Nice Easter present. thankee!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks a bundle. :)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)