In D7 some of the library names were deprecated, we should clean that up in D8.

CommentFileSizeAuthor
#5 1341186.patch1.48 KBRobLoach
#1 1341186.patch788 bytesericduran
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericduran’s picture

ericduran CreditAttribution: ericduran commented
FileSize
1341186.patch788 bytes

Simple patch.

ericduran’s picture

ericduran CreditAttribution: ericduran commented
Status: Active » Needs review
Issue tags: +JavaScript

Updating status, and Tag.

Status: Needs review » Needs work

The last submitted patch, 1341186.patch, failed testing.

ericduran’s picture

ericduran CreditAttribution: ericduran commented

Hmm, we shouldn't be using those libraries. :-/

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1341186.patch1.48 KB

I think I found it.

ericduran’s picture

ericduran CreditAttribution: ericduran commented

Ha, I totally failed at finding that one.

ericduran’s picture

ericduran CreditAttribution: ericduran commented
Status: Needs review » Reviewed & tested by the community

This is a pretty simple one.

ericduran’s picture

ericduran CreditAttribution: ericduran commented

#5: 1341186.patch queued for re-testing.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Title: Remove deprecated Library names » Change notice for: Remove deprecated Library names
Priority: Normal » Critical
Status: Reviewed & tested by the community » Active

Nice. Committed/pushed to 8.x.

This is technically an API change, so will need a change notice.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Priority: Critical » Normal
Status: Active » Fixed

http://drupal.org/node/1389386

ericduran’s picture

ericduran CreditAttribution: ericduran commented
Title: Change notice for: Remove deprecated Library names » Remove deprecated Library

The title needs to be changed back ;-)

Automatically closed -- issue fixed for 2 weeks with no activity.