There are three mistakes in system_menu in system.module

Values of 'title' and 'description' in menu items should not be passed to function t.

The following lines have this problem:
980
981
972

CommentFileSizeAuthor
#8 systemmenu-133608-8.patch1.2 KBpjcdawkins
#5 systemmenu-1336308-5.patch1.22 KBkathyh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sebto’s picture

sebto CreditAttribution: sebto commented
Assigned: Unassigned » sebto
Priority: Normal » Major
sebto’s picture

sebto CreditAttribution: sebto commented
Assigned: sebto » Unassigned
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Version: 7.9 » 8.x-dev
Priority: Major » Normal
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Issue tags: +Novice

This would be a good issue for a novice to patch.

kathyh’s picture

kathyh CreditAttribution: kathyh commented
Status: Active » Needs review
FileSize
systemmenu-1336308-5.patch1.22 KB

Patch to fix values of 'title' and 'description' in menu items should not be passed to function t in system.module.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs backport to D7

Excellent. Exists in D7 too, but not in D6.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed/pushed to 8.x, moving to 7.x for backport.

pjcdawkins’s picture

pjcdawkins CreditAttribution: pjcdawkins commented
Status: Patch (to be ported) » Needs review
FileSize
systemmenu-133608-8.patch1.2 KB

It took a solid 15 minutes to run git clone but hopefully it was worth it - here you go, my first attempt at a core patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Well done! :) Applies perfectly!

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.