When the help module is not enabled, "Get help" links should not be displayed since they link to 404s.
Or at least they should contain a warning "If you want to view this help page, please enable the help module" with a link to the module page.

CommentFileSizeAuthor
#10 system-admin.patch1.01 KBwmostrey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Frando’s picture

Frando CreditAttribution: Frando commented

The alternative would be to move all help texts to a modulename.help file and allow viewing the help texts even when the module is disabled .. Hmm...

intu.cz’s picture

intu.cz CreditAttribution: intu.cz commented

I disabled the help module on a fresh 6.x.dev install, and where exactly do I find the "Get help" links? Could you please specify a page where I can find an example and try to reproduce the bug? Thanks.

ScoutBaker’s picture

ScoutBaker CreditAttribution: ScoutBaker commented

[edit] @aurka, this was supposed to be a reply to your comment.

I was able to reproduce this in 6.0-beta3 (currently a default installation except for disabling the Help Module).

If you select Administer-By module, under each module, the last option is Get Help. With the Help module enabled, you get a help page describing the feature/module. If the Help module is disabled, you receive a "Page not found" error.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

Yes, those links are present whether the help module is enabled or not, not very pretty.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented

I'm willing to patch this. What should we do with them:

  1. Remove them
  2. Link to a page with a warning "If you want to view this help page, please enable the help module" with
    • a link to the module page
    • a link to the admin's contact page if the user doesn't have privileges to enabled modules
    • a link to the admin's email address when the admin doesn't have the contact module enabled for him
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I'd go for 1.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented

Go with 1.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Assigned: Unassigned » wmostrey
ScoutBaker’s picture

ScoutBaker CreditAttribution: ScoutBaker commented

Go for #1, that was what I was planning to try my hand at. I didn't have time to create a patch and test last night.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented
Status: Active » Needs review
FileSize
system-admin.patch1.01 KB

There, a nice clean patch.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Nice and clean, works as advertised. Not nice at all to have help links pointing to 404s.

wmostrey’s picture

wmostrey CreditAttribution: wmostrey commented

This might be a whole other discussion but I wonder if we need drupal_help_arg() in menu.inc instead of in the help module? When this patch is applied, it will only be called if the help module exists. The only other place it's called is from modules/search/search.pages.inc.

Either way, this patch needs to go in first and separately.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.