There was an issue about it #1309298: Document that hook_(en|dis)able implementations should live in .install files

CommentFileSizeAuthor
#6 commerce_examples-moved-hook-enabled-1325746-5.patch2.03 KBmakangus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented

Thanks - I didn't know that. You don't have any idea why it matters do you?

I think we have it in .module in commerce in general.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

No matter just remembered about this change in 8

rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Component: Code » Line Item Example
Status: Active » Fixed

Moved in http://drupalcode.org/project/commerce_examples.git/commitdiff/c141076

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

bobbyaldol’s picture

bobbyaldol CreditAttribution: bobbyaldol commented
Component: Line Item Example » Order Example
Assigned: Unassigned » bobbyaldol
Status: Closed (fixed) » Active

The hook_enable for the Order Example module still resides in the .module file rather than in the .install file.

makangus’s picture

makangus CreditAttribution: makangus commented
Status: Active » Needs review
FileSize
commerce_examples-moved-hook-enabled-1325746-5.patch2.03 KB

Playing around, thought I would close your last opened bug.

bobbyaldol’s picture

bobbyaldol CreditAttribution: bobbyaldol commented
Status: Needs review » Closed (fixed)
rfay’s picture

rfay
Primary language English
Location Palisade, CO, USA
CreditAttribution: rfay commented
Status: Closed (fixed) » Fixed

As mentioned in #1841306-04: PHP Notice when user is Anonymous

Thanks for maintaining this!

bobbyaldol’s picture

bobbyaldol CreditAttribution: bobbyaldol commented

@rfay: I thank you for giving me this opportunity to learn something new and guiding me all the way for the last three months.
I wish I could devote more time to this.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.