Empty tokens don't get replaced in welcome emails [#1300298]

You can use tokens in the welcome emails available at admin/config/people/accounts/settings

Hoewever, when a token is empty it will be rendered as the actual token replacement string in the email.

For example:

Dear [user:field_firstname] [user:field_preposition] [user:field_lastname],

becomes this in the email:

Dear John [user:field_preposition] Doe,

This is because user.module does not use the "clear" option for the token_replace function as described here:
http://drupal.org/node/1272028

The patch attached adds this option to the function in user.module.

Comment	File	Size	Author
#7	user-token-replace-1300298-7.patch	721 bytes	askibinski
#7
#5	user-token-replace-1300298-5.patch	726 bytes	askibinski
#5
#3	user-token-replace-1300298-3.patch	725 bytes	askibinski
#3
	token_replace_user_module.patch	605 bytes	askibinski

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

5 October 2011 at 14:45

Status:

Needs review

» Needs work

The last submitted patch, token_replace_user_module.patch, failed testing.

Comment #2

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 6 October 2011 at 01:32

Version:	7.8	» 8.x-dev
Issue tags:		+token

Bugs have to be fixed in 8.x first, then backported to 7.x. I approve of this change, we just need a patch rolled with the correct format.

Comment #3

askibinski CreditAttribution: askibinski commented 12 October 2011 at 12:14

Status:

Needs work

» Needs review

File	Size
user-token-replace-1300298-3.patch	725 bytes

Here is a patch against 8.x according to the patch guidelines. Should be okay...

Comment #4

attiks CreditAttribution: attiks commented 12 October 2011 at 13:23

Status:

Needs review

» Needs work

+++ b/modules/user/user.moduleundefined
@@ -2691,7 +2691,7 @@ Your account on [site:name] has been canceled.
     // We do not sanitize the token replacement, since the output of this

Comment says not to sanitize, but your code has 'sanitize' => TRUE, used to be FALSE, why the need to change it?

-10 days to next Drupal core point release.

Comment #5

askibinski CreditAttribution: askibinski commented 12 October 2011 at 20:26

Status:

Needs work

» Needs review

File	Size
user-token-replace-1300298-5.patch	726 bytes

Woops.... how did that get in there... sorry. Here is a reroll!

Comment #6

attiks CreditAttribution: attiks commented 12 October 2011 at 20:31

Look better ;p

Comment #7

askibinski CreditAttribution: askibinski commented 2 November 2011 at 20:28

File	Size
user-token-replace-1300298-7.patch	721 bytes

Rerolled the patch for the new core directory structure.

Comment #8

mariagwyn CreditAttribution: mariagwyn commented 19 December 2011 at 17:42

Does this need to be tested? I need this since I just discovered this problem and need to send a whole slew of emails to users who are about to be activated. I am rather hesitant to apply a patch to a core module on my site....