Hi. Manual capture through administration pages doesn't work. At first, form callback named commerce_payflow_pro_capture_form(), but validator and submitter called commerce_paypal_direct_capture_form_validate() and commerce_paypal_direct_capture_form_submit() accordingly, so they actually never called. They should called commerce_payflow_pro_capture_form_validate() and commerce_payflow_pro_capture_form_submit().
Also, submitter uses wrong API parameter ORGINID (should be ORIGID). And there is no reason to pass TENDER parameter.

I didn't investigated code of the commerce_payflow_pro.admin.inc in details, so I'm not sure that these are the only bugs and manual capture will work after fixing.

Thanks.

Comments

antongp’s picture

antongp commented

BTW, how about to use
'TRXTYPE' => commerce_payflow_pro_txn_type(COMMERCE_CREDIT_PRIOR_AUTH_CAPTURE)
instead of
'TRXTYPE' => 'D'

It makes code more abstract :).

markie’s picture

markie commented
Assigned: Unassigned » markie
Status: Active » Needs review

Updated per your suggestions. It's late so I pushed it up and will test it in the morning. Please feel free to hurt me if it fails on something stupid.

markie’s picture

markie commented

I tested it locally and was able to process a payment through the admin area.

markie’s picture

markie commented
Status: Needs review » Closed (fixed)

Fixed