Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Over in #1283892: Let Render API fail in a tale-telling way on invalid $element, an error message is added to help debug invalid render arrays, i.e., a key that does not begin with # and whose value is not an array. This exposed a bug in the toolbar, its method of adding a class.
Instead of manually building up the classes array, then imploding it, then printing it, why not use '#type' => 'container' and #attributes?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | drupal-1285098-1.patch | 1.03 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettNote, this does not attempt to fix #1215304: Toolbar incorrectly add whitespace to body when there's no expandable content to fill it at all, but does not affect it either.
Comment #2
sunLooks good to me.
Also, +1 for backporting identically, even though it changes a theme template.
Comment #3
Dries CreditAttribution: Dries commentedCommitted to 8.x.
I'm leaning towards not backporting this to 7.x as it requires templates to be updated. In other words, this change can break existing sites. Leaving for webchick to consider.
Comment #4
webchickAgreed. People running into the issue of empty divs will have already worked around it in their themes. Happy to see this fixed in D8 though.