Currently, all the taskbar items can be toggled individually and the module allow more than one taskbar items to be active and expanded at one time. But they stack on top of one another, which may not be ideal for some use cases. This patch is to offer a setting available in the taskbar UI for automatically closing/deactivating other active taskbar items, when a new taskbar item is selected, which is forcing only one active item visible at a time, so the taskbar behaves more like regular drop-down navigation. This setting can be turned on and off via taskbar UI.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | taskbar_autoclose.patch | 2.21 KB | McChen |
| taskbar_autoclose.patch | 2.2 KB | McChen |
Comments
Comment #1
hefox commentedSpacing issues (tabs instead of two spaces I'd guess), but looks good to me other than that.
Comment #2
McChen commentedThanks, hefox. I've cleaned up the tabs and will turn on invisible characters from now on.
Comment #3
icecreamyou commentedIMO this setting should be on by default. But thehong or jcisio should weigh in on that before making that change.
Also the variable this patch adds needs to be removed when the module is uninstalled. (Actually, Taskbar has a couple of variables that it needs to remove on uninstall but currently doesn't... but that doesn't mean this patch shouldn't do it.)
Other than that, looks like a good solution to me.
Comment #4
jcisio commentedI think we can keep it off by default, as it is the current behavior (and I think that it's quite practical to have a few items open :P).
I let this issue fixed then create a follow up #1281162: Taskbar leaves variables when uninstalled so that we can have this feature in dev soon ;-)
Thanks all.
Comment #6
jcisio commentedThere was a bug that prevented Ajax enabled items from being closed. It has been fixed with fd3a70e (D7) and c4398d3 (D6).