Email from name encoding [#1277792]

I think line 250 of print_mail/print_mail.inc
$from = '"'. $form_state['values']['fld_from_name'] .'" <'. $form_state['values']['fld_from_addr'] .'>';
should look like this
$from = '"'. addslashes(mime_header_encode($form_state['values']['fld_from_name'])) .'" <'. $form_state['values']['fld_from_addr'] .'>';

It fixed a bug for users with non ASCII characters in their names on my website.

Comments

Comment #1

jcnventura CreditAttribution: jcnventura commented 13 September 2011 at 15:55

Hi,

Can you tell me an example of such a username??

Comment #2

kargal CreditAttribution: kargal commented 28 September 2011 at 11:22

Some examples :
Dorothée
Andrée
Laëtitia

Kind of firstnames you don't usually see with an american or english community ;)

Comment #3

jcnventura CreditAttribution: jcnventura commented 28 September 2011 at 22:28

Well, my first name is João, so I certainly relate to that.

I think I see what the bug is. :) I'll try to see what I can do.

João

Comment #4

jcnventura CreditAttribution: jcnventura commented 28 September 2011 at 22:29

Status:

Active

» Needs review

Comment #5

jcnventura CreditAttribution: jcnventura commented 11 October 2011 at 16:29

Status:

Needs review

» Fixed

Thanks for the suggestion.

After reading the documentation, of mime_header_encode(), I concluded that in no occasion would the addslashes() call be needed, so I didn't use that.

Committed to git.