Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
API page: http://api.drupal.org/api/drupal/modules--block--block.module/function/b...
Describe the problem you have found:
$block is not a parameter:
$block object for $module.
Comment | File | Size | Author |
---|---|---|---|
#4 | blockParamFormatting-1275214.patch | 495 bytes | cashwilliams |
Comments
Comment #1
dawehnerOh this one is nice. Here is the original block in php
So the amount of signs is exactly that it looks like it would be another parameter.
This seems to be that there should be a kind of styling for the next param.
Comment #2
jhodgdonI think you're just objecting to this:
when $block is not actually a variable.
OK. That's a valid point. $block here should just be "block", as in "return an empty block object...". Sounds like a good project for a novice contributor to learn how to make a patch!
Comment #3
lukusI'd be happy to learn how to make a patch - please point me in the right direction ..
Comment #4
cashwilliams CreditAttribution: cashwilliams commentedlukus - I just followed the steps on this page - http://drupal.org/project/drupal/git-instructions
Not sure about how to properly name this patch.
Comment #5
jhodgdonhttp://drupal.org/documentation/git - learn about Git
http://drupal.org/node/707484 - patching specifics
Comment #6
jhodgdonSorry, cross-post! Looks like you found some instructions. :)
The patch looks fine (assuming the test bot agrees), and should apply to d7 and d8. Thanks!
Comment #7
jhodgdonOh, and regarding patch naming - the name you chose is fine. Usually people put the issue number and a description in the name, which you did.
Comment #8
Dries CreditAttribution: Dries commentedCommitted to 7.x and 8.x.
Comment #9
lukusThx for the info - I'll be good to go next time.