Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The attached patch addresses the following PHP warnings seen during initial install of Aegir:
During "site-verify" for Aegir hostmaster site:
Undefined property: stdClass::$task_args hosting_task.module:572
Undefined property: stdClass::$db_passwd hosting_db_server.module:52
Undefined index: db hosting_server.module:170
Undefined property: stdClass::$revision hosting_server.module:316
Undefined property: stdClass::$task_args hosting_task.module:548
Undefined variable: additions hosting_client.module:882
During "server-verify" for "localhost":
Undefined property: stdClass::$task_args hosting_task.module:572
Undefined property: stdClass::$db_passwd hosting_db_server.module:52
Undefined index: http hosting_server.module:170
Undefined property: stdClass::$revision hosting_server.module:316
During "site-import" for Aegir hostmaster site:
Undefined variable: additions hosting_client.module:882
Undefined property: stdClass::$task_args hosting_task.module:572
Undefined property: stdClass::$revision hosting_site.nodeapi.inc:168
Undefined property: stdClass::$revision hosting_package.module:265
Undefined index: gid hosting_client.access.inc:239
| Comment | File | Size | Author |
|---|---|---|---|
| hostmaster_multiple_warnings_on_install.patch | 6.9 KB | GuyPaddock |
Comments
Comment #1
Steven Jones CreditAttribution: Steven Jones commentedThanks for this, I've added most of your changes from the patch, tidying up as I went, but I've not added the hunk for
hosting_package_syncas in theory that code doesn't need to be called by Drush, and also because we can safely assume that we are called with an array. It is the responsibility of the calling code to pass us an array and not some random junk.There are going to be a lot more places in Aegir that need an
issetor!emptyadding...the codebase is quite crufty in some places.Comment #2
Steven Jones CreditAttribution: Steven Jones commentedMarking as fixed as all the usable code got committed.