Little modernization of language_default() [#1265700]

The property argument of language_default() is at best laughable in these days of object chaining. It was really supposed to be a quick convenience feature, but its more like cruft that is already not used consistently in code (some places already use the proper object chaining syntax). We can just get rid of this and use it as a simpler API.

Parent issue

#1260488: META: Introduce real language APIs

Comment	File	Size	Author
#2	modernize-language-default.patch	5.31 KB	Gábor Hojtsy
#2
	modernize-language-default.patch	5.21 KB	Gábor Hojtsy

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 31 August 2011 at 19:42

Status:

Needs review

» Needs work

+++ b/includes/bootstrap.inc
@@ -2558,14 +2558,13 @@ function language_list($field = 'language') {
+  return variable_get('language_default', (object) array('language' => 'en', 'name' => 'English', 'native' => 'English', 'direction' => 0, 'enabled' => 1, 'plurals' => 0, 'formula' => '', 'domain' => '', 'prefix' => '', 'weight' => 0, 'javascript' => ''));

In terms of "modernizing" can we split that out into separate lines, while we're at it?

Otherwise looks very good.

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 1 September 2011 at 07:31

Status:

Needs work

» Needs review

File	Size
modernize-language-default.patch	5.31 KB

Looks good?

Comment #3

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 1 September 2011 at 09:51

Status:

Needs review

» Reviewed & tested by the community

Awesome, thanks!

Comment #4

sun

German

Karlsruhe

CreditAttribution: sun commented 7 September 2011 at 23:45

+++ b/includes/bootstrap.inc
@@ -2558,14 +2558,28 @@ function language_list($field = 'language') {
+function language_default() {
+  return variable_get(
+    'language_default',

Hold on - we're storing a full object in a variable...?

Hope there's already a follow-up issue to clean that up.

20 days to next Drupal core point release.