Patch loosens entity_property_values_create_entity(), and allows passing keys that have no metadata property.

CommentFileSizeAuthor
#1 create-entity-property-2.patch1.32 KBamitaibu
create-entity-property-1.patch1.32 KBamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
create-entity-property-2.patch1.32 KB

And this one is without a typo ;)

fago’s picture

fago
Primary language German
Location Vienna
CreditAttribution: fago commented
Status: Needs review » Fixed

Makes sense. Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Closed (fixed) » Active

Why? RESTWS relied on this behaviour so that incoming entities with unknown properties were not created. Therefore a RESTWS test case is currently failing.

Updating entities with unknown properties still fails as expected, because the wrapper is used directly. Guess I cannot use entity_property_values_create_entity() anymore and will also have to use the wrapper directly for creation.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
CreditAttribution: klausi commented
Status: Active » Closed (fixed)

Well, I can see that this change might be necessary for other modules. So I posted a patch in #1303000: Creating entities with unknown properties should not be possible to fix it in RESTWS.