The links for login and register to post new comments does not refer to the actual form upon login. It just points to the top of the node. This is due to the "#form_comment" instead of "#form-comment". I have attached the needed patch.

A simple thing, but it was bugging our project manager, so I thought I would fix and submit.

Greg

CommentFileSizeAuthor
#2 comment.module_70.patch590 bytesGman
comment.module_69.patch596 bytesGman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joemoraca’s picture

joemoraca CreditAttribution: joemoraca commented

patch would not apply line numbers were way off...

Gman’s picture

Gman CreditAttribution: Gman commented
FileSize
comment.module_70.patch590 bytes

Sorry about that. I don't know how that happened. Take from the current version of HEAD.

-Greg

ChrisKennedy’s picture

ChrisKennedy CreditAttribution: ChrisKennedy commented

Comments were recently fixed in head (see http://drupal.org/node/124742), which is probably why the line numbers were off.

Anyway, when you roll a patch a) please roll it from the root drupal directory so that it can easily be applied b) use -up as options to your diff so that the context can be quickly seen. More info at http://drupal.org/patch

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

The patch did not apply but I re-rolled it for you and committed it to CVS HEAD and DRUPAL-5. Good catch, and kudos to your project manager. ;-)

Gman’s picture

Gman CreditAttribution: Gman commented

Thanks. I will make sure to adjust my patching notes to conform to the above link.

First patch to core! Hope to contribute in bigger ways in the future. :)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)