Provide Rules events for entity view [#1236882]

This patch adds Rules events for hook_ENTITY_view(). As the EntityAPIController already invokes the event, adding the Rules event definition in entity.rules.inc was enough. The event itself works, but I'm still facing problems when using the view mode variable in a data comparison condition (Fatal error: Unsupported operand types in includes/form.inc on line 2525). As this happens for the node view as well, this problem seems to be an Rules issue.

Comment	File	Size	Author
#4	entity_rules_view_event3.patch	1.62 KB	mh86
#4
#2	entity_rules_view_event2.patch	1.15 KB	mh86
#2
	entity_rules_view_event.patch	1011 bytes	mh86

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fago

German

Vienna

CreditAttribution: fago commented 3 August 2011 at 11:12

indeed, options lists for event variables were completely broken in Rules as the wrappers didn't work in that case. I've just fixed that in entity + rules, so the node-view view-modes now work for me in Rules.

To fix the patch we'll need to add something like

+          // Add the entity-type for the options list callback.
+          'options list entity type' => 'node',

to the view-mode variable info array.

Comment #2

mh86 CreditAttribution: mh86 commented 3 August 2011 at 11:56

Status:

Needs work

» Needs review

File	Size
entity_rules_view_event2.patch	1.15 KB

Updated the patch for the latest Rules fix. Furthermore, the view mode variable will only be added to entities with some view modes.

Comment #3

fago

German

Vienna

CreditAttribution: fago commented 3 August 2011 at 14:26

Status:

Needs review

» Fixed

thanks, committed.

Comment #4

mh86 CreditAttribution: mh86 commented 4 August 2011 at 08:47

Status:

Fixed

» Needs review

File	Size
entity_rules_view_event3.patch	1.62 KB

updated the patch to only expose the view event for entities with view modes. For the other entities we assume that they don't use entity view anyway.