Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We might consider using a section or an article tag for the wrapper.
Relates to : #1189816: Convert comment.tpl.php to HTML5
Comment | File | Size | Author |
---|---|---|---|
#7 | comment-wrapper-1229434.patch | 798 bytes | Jeff Burnz |
Comments
Comment #1
jessebeach CreditAttribution: jessebeach commentedDerp, forgot to change comment.tpl.php to comment-wrapper.tpl.php.
Comment #2
jessebeach CreditAttribution: jessebeach commentedadded html5 tag
Comment #3
Jacinetagging!
Comment #7
Jeff Burnz CreditAttribution: Jeff Burnz commentedsection seems to make sense, nodes and comments as articles, with section as the wrapper,
Comment #8
Lars Toomre CreditAttribution: Lars Toomre commentedThere is another double >> in the line:
Rereading carefully, skip the above... But now am wondering if print $attributes includes a space before first attribute if $attributes is not empty.
Comment #9
Jeff Burnz CreditAttribution: Jeff Burnz commentedOnly thing actually changed is the element (swapped div for section), everything else is the same.
Comment #10
Anonymous (not verified) CreditAttribution: Anonymous commentedTested and this works (when using Seven theme).
It makes sense to use section for this, it is an area of content that has a heading but that doesn't make sense as an article.
RTBC
Comment #11
JacineSweet! Nice work guys ;)
This is still RTBC, just updating the sprint tag to keep track of it while we wait.
Comment #12
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #13
Jeff Burnz CreditAttribution: Jeff Burnz commentedAssuming fixed? Hooray, my first patch for Drupal 8 - very chuffed :)
Comment #14
JacineSweet! Congrats Jeff :D
Comment #15
jessebeach CreditAttribution: jessebeach commentedcongrats Jeff!
Comment #17
cosmicdreams CreditAttribution: cosmicdreams commentedI see that the comment section still has an "id='comment'" attribute. Did we want to eliminate the use of ids in our markup or am I remembering that wrong.
Comment #18
Jeff Burnz CreditAttribution: Jeff Burnz commentedRemoving ID's is a totally separate issue, I dont know if there is an open issue for this.
Comment #19
JacineNothing else needs to be done here. #comments ID is a useful anchor that we shouldn't remove IMO.
Comment #20
JacineCleaning up tags/component.
Comment #20.0
Jacineadded cross link to comment.tpl.php conversion issue