Part of the CSS Cleanup: http://drupal.org/node/1089868

CommentFileSizeAuthor
#16 1216972-color_module-css-clean-up-16.patch3.85 KBoresh
#14 1216972-color-module-css-cleanup-14.patch2.69 KBoresh
#9 1216972-9.patch2.46 KBJacine
#6 drupal-1216972-6.patch1.39 KBtim.plunkett
#5 css-cleanup-color-module.patch5.48 KBaspilicious
#4 color-module-css-cleanup.patch8.29 KBaspilicious
#1 color-module-css-cleanup.patch8.29 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
FileSize
color-module-css-cleanup.patch8.29 KB

First step in fixing this mess :).
Probably needs lots of work. Needs review for the approach.

Status: Needs review » Needs work

The last submitted patch, color-module-css-cleanup.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Anyway this patch is plain wrong :). I changed the structual design.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
color-module-css-cleanup.patch8.29 KB

Better?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
css-cleanup-color-module.patch5.48 KB

Whoops wrong patch

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
drupal-1216972-6.patch1.39 KB

With moves as renames, to clarify that nothing has changed. No patch credit.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Still aspilicious's patch.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Jacine’s picture

Jacine
she/her
Location New York
CreditAttribution: Jacine commented
Status: Fixed » Needs review
FileSize
1216972-9.patch2.46 KB

Dries, the files that were renamed were missing from this commit.

Here's a patch to add them.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

R T B C it is

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Priority: Normal » Major

And again, as long as Color module is in core, the missing CSS at least qualifies as major.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed them now. Odd.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

oresh’s picture

oresh CreditAttribution: oresh commented
FileSize
1216972-color-module-css-cleanup-14.patch2.69 KB

Some js + css performance clean up.
Not a lot, just:
in css combining selector with the same styles
in js combining variables into one var for a small performance boost.

oresh’s picture

oresh CreditAttribution: oresh commented
Status: Closed (fixed) » Needs review
oresh’s picture

oresh CreditAttribution: oresh commented
FileSize
1216972-color_module-css-clean-up-16.patch3.85 KB

A newer patch for latest build.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Closed (fixed)

Create a new issue.

oresh’s picture

oresh CreditAttribution: oresh commented

follow-up issue #1969132: Clean up the CSS for Color module