Just wondering if you're planning a D7 Port?

Comments

JuliaKM’s picture

StatusFileSize
new13.34 KB

This is a first stab at a user merge Drupal 7 port. I started a new function to merge profile fields but it is not fully working. In addition, the functionality to merge OG and notifications information is not working. However, when testing locally, I was able to consistently merge basic user account data (data found in in usermerge_usermerge_merge_users).

greggles’s picture

Title: Drupal 7 port » Drupal 7 port of user merge
Status: Active » Needs work

Thanks for your work!

I think it's fine to focus on core features and add contributed modules later. Who knows whether notifications/OG will be as popular for Drupal 7 as they are for Drupal 6.

I think we should just remove that code for now and note them as issues in the queue here.

All comments should be capitalized sentences with punctuation at the end.

Can you expand on the "TODO: Update for Field API" like explain that this would be important for fields attached to users. Also, maybe create an issue and add the URL of the issue.

This looks really close. If you can clean these things up I will make a new branch, commit them, and we can do clean up patches from that point.

JuliaKM’s picture

Status: Needs work » Needs review
StatusFileSize
new10.53 KB

Thanks for your help!

Here's a revised patch. The code for OG and notifications is gone and comments are now real sentences. I also created a new issue for profile field merging with the new API (#1244532: Add Drupal 7 Support for Profile Merging with Field API) that needs to be reassigned to branch 7 once it exists.

greggles’s picture

Status: Needs review » Fixed

Great, thanks JuliaKM! Committed with attribution http://drupalcode.org/project/usermerge.git/commit/d84e1d0 :)

I also added a note to the project page, removed the "master" branch in favor of real 6.x-1.x and 7.x-1.x branches, and created a dev release at http://drupal.org/node/1245052 which will show up in ~12 hours. Hopefully I'll remember to mark it supported on the project page so we can get some testers...

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit d84e1d0 on 7.x-1.x, 8.x-1.x, 7.x-2.x, 7.x-2.x-api authored by JuliaKM, committed by greggles:
    Issue #1203596 by JuliaKM: Drupal 7 port of user merge