Scenario: Non-administrative users are allowed to create forum topics, but these topics are created unpublished pending administrative approval.

This is what a user who creates a forum topic sees:

Access denied

Your forum topic was created.

You are not authorized to access this page.

Um, yeah.

Comments

kps’s picture

Component: forum.module » node.module

The attached patch sends the user to the front page instead of the newly created node, if they don't have permission to view it.

kps’s picture

Lovely. Drupal.org doesn't have an upload directory right now, so it lets me attach a file, then... throws it away. Oh well, that's for another bug report.

--- node.module	Sat Oct 23 12:47:20 2004
+++ node.module	Thu Nov 11 18:43:20 2004
@@ -1377,7 +1377,12 @@ function node_submit($node) {
 
   // Node was submitted successfully. Redirect to the viewing page.
   drupal_set_message($msg);
-  drupal_goto('node/'. $node->nid);
+  if (node_access('view', $node)) {
+    drupal_goto('node/'. $node->nid);
+  }
+  else {
+    drupal_goto('');
+  }
 }
 
 /**
kps’s picture

Hmm, on second thought I like this better:

--- node.module	Sat Oct 23 12:47:20 2004
+++ node.module	Thu Nov 11 18:56:54 2004
@@ -1376,8 +1376,13 @@ function node_submit($node) {
   }
 
   // Node was submitted successfully. Redirect to the viewing page.
-  drupal_set_message($msg);
-  drupal_goto('node/'. $node->nid);
+  if (node_access('view', $node)) {
+    drupal_set_message($msg);
+    drupal_goto('node/'. $node->nid);
+  }
+  else {
+    return $msg;
+  }
 }
 
 /**
Dries’s picture

Committed to HEAD and DRUPAL-4-5. I used the first patch because that makes for the most consistent approach: status messages are reported using drupal_set_message(). Thanks kps.

Anonymous’s picture

Jurjen de Vries’s picture

Version: » 6.9
Status: Closed (fixed) » Active

This bug is back again in Drupal 6.

Jody Lynn’s picture

Status: Active » Closed (cannot reproduce)

Please open a new issue and explain steps to reproduce if this problem exists. It's not really relevant to a conversation from 2004.