The following notice is appearing on every page:

Notice: Undefined variable: result in dmemcache_get() (line 107 of sites/all/modules/memcache/dmemcache.inc)

The reason is that dmemcache_get() defines a variable called $success but actually returns a variable called $result.

CommentFileSizeAuthor
#4 dmemcache_get-fix_undefined_variable-1190426-4.patch831 bytespillarsdotnet
#1 dmemcache_get-undefined_result-1190426-1.patch694 bytespillarsdotnet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
Status: Active » Needs review
FileSize
dmemcache_get-undefined_result-1190426-1.patch694 bytes

Patch/fix:

jghyde’s picture

jghyde CreditAttribution: jghyde commented

Patch tested and appears to fix the problem on latest Drupal 7.3-dev

teddyboar’s picture

teddyboar CreditAttribution: teddyboar commented

Had the same error message in the logs; tested the patch and it fixes the problem.

pillarsdotnet’s picture

pillarsdotnet CreditAttribution: pillarsdotnet commented
FileSize
dmemcache_get-fix_undefined_variable-1190426-4.patch831 bytes

Unfortunately, the patch in #1 is absolutely wrong.

Here is a corrected patch.

teddyboar’s picture

teddyboar CreditAttribution: teddyboar commented

Well, patch in #4 was my first thought too at first sight (regarding the behavior in dmemcache_get_multi() for example). After a better look, patch #1 only removed the error message.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Fixed

Thanks! Committed and pushed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jan.s’s picture

jan.s CreditAttribution: jan.s commented
Priority: Normal » Critical
Status: Closed (fixed) » Needs work

Committed yes, but not included in 7.x-1.0-rc1 !

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Priority: Critical » Normal
Status: Needs work » Closed (fixed)

It's not supposed to.

7.x-1.0-rc1 is an old outdated version and is not supposed to be used. Use 7.x-0.2.

jan.s’s picture

jan.s CreditAttribution: jan.s commented

Version 7.x-0.2 does not include this patch.

jan.s’s picture

jan.s CreditAttribution: jan.s commented
Status: Closed (fixed) » Active

Berdir, 7.x-1.0-rc1 was released later than 7.x-0.2. Why do you think it is outdated?

Nevertheless, both releases do not include the patch. In addition the releases have been released months after reporting the bug and providing the patch. So I will reopen this ticket. Correct me, if I'm wrong.

jan.s’s picture

jan.s CreditAttribution: jan.s commented
Version: 7.x-1.x-dev » 7.x-1.0-rc1
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Active » Needs work

I can't see this in the 7.x-1.x branch, but neither does the patch apply any more, so this will need a re-roll.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Version: 7.x-1.0-rc1 » 7.x-1.x-dev

I think this is also being dealt with in #1184678: Enhance failure tolerance.

Sorry about the confusion re the version number, I meant 1.0-beta4.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Postponed (maintainer needs more info)

The linked issue has been commited, can anyone confirm that this is resolved?

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Yes, the 7.x-1.x-dev codebase does have the fix present.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed
jan.s’s picture

jan.s CreditAttribution: jan.s commented
Status: Fixed » Closed (fixed)

Thank you!

7.x-1.0-rc2 is working as expected.