API page: http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hoo...
Describe the problem you have found:
> function: If specified, this will be the function name to invoke for this implementation. If neither file nor function is specified, a default function name will be assumed. For example, if a module registers the 'node' theme hook, 'theme_node' will be assigned to its function. If the chameleon theme registers the node hook, it will be assigned 'chameleon_node' as its function.
I *think* that should say 'neither template nor function'.
Comment | File | Size | Author |
---|---|---|---|
#14 | doc-hook-theme-D6.patch | 6.77 KB | sven.lauer |
#8 | hook_theme_doc-1190110-8.patch | 4.48 KB | oriol_e9g |
#3 | hook_theme_doc-1190110-4.patch | 817 bytes | oriol_e9g |
Comments
Comment #1
jhodgdonI agree that you are correct, it should say "If neither template nor function is specified, ...". Good project for a novice doc contributor!
Comment #2
jhodgdonAnd it's a problem in D6/7/8
Comment #3
oriol_e9gTry with this.
Comment #5
oriol_e9g#3: hook_theme_doc-1190110-4.patch queued for re-testing.
Comment #6
joachim CreditAttribution: joachim commentedLooks good to me.
Though I notice that the key names should be in quotes, like 'path' above.
But that could be left to another issue -- maintainer's call :)
Comment #7
jhodgdonI agree with Joachim - it would be nice to put 'template' and 'file' in quotes.
Comment #8
oriol_e9gKey names in quotes and comments wrapped to 80 chars
Comment #9
oriol_e9gComment #10
jhodgdonLooks good to me, for 7.x/8.x please. Thanks!
Comment #11
webchickCommitted and pushed to 8.x and 7.x. Thanks!
Comment #12
webchickOops. I guess this needs backport to D6 too.
Comment #13
jhodgdonOh and for d6 it's in the docs project
Comment #14
sven.lauer CreditAttribution: sven.lauer commentedRe-rolling for D6. There also were a number of wrapping issues in hook_theme's doc, which I took care of with this patch as well (+slight rewording in the intro paragraph: "info"->"information").
Comment #15
jhodgdoncommitted, thanks!