Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When creating a new state, the state name is not checked against existing state names. So it's no problem to create several states with the same state name.
I'm not sure there whether this could be useful in some special cases, but the user should at least be warned and asked to confirm.
Comment | File | Size | Author |
---|---|---|---|
#2 | workflow_and_state_validation.patch | 13.79 KB | Pancho |
Comments
Comment #1
PanchoSame with workflow names... at least a confirmation message would be helpful to avoid confusion.
Comment #2
PanchoOkay now, this is the last patch for today...
it's a bit bigger than the others. What I'm doing here is:
I tested this as much as possible and it worked out very well. Please test it yourself. I expect no new bugs, but if there is a minor one, please commit the patch anyway and tell me what to correct. Rest assured, the total count of bugs will go down with this ;-) Of the rest I'll take care, as I need this module in a perfect condition for a project...
Comment #3
mfredrickson CreditAttribution: mfredrickson commentedThanks for all this stuff.
I committed it with two exceptions:
1. Use of return "path/for/user" is preferred to drupal_goto("path/for/user") in _submit hooks.
2. I moved the "Author must have at least 1 transition" message to the validate hook. It makes the most sense here and actually allows users to correct the error before moving on.
Thanks again!
Comment #4
(not verified) CreditAttribution: commented