There was a portion which cannot be translated in filter.module & throttle.module. Since function t() was added, I need your help well.

CommentFileSizeAuthor
#5 drupal_6811.72 KBp_____n
#3 drupal_671.09 KBp_____n
#1 drupal_664.15 KBp_____n
drupal_65800 bytesp_____n
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

p_____n’s picture

p_____n CreditAttribution: p_____n commented
FileSize
drupal_664.15 KB

The appending here is throttle.module.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented

The file contains a patch to filter.module.

p_____n’s picture

p_____n CreditAttribution: p_____n commented
FileSize
drupal_671.09 KB

Please add one more. It was also in statistics.module.

p_____n’s picture

p_____n CreditAttribution: p_____n commented

Since there are likely to be several places in other modules, I want to investigate a few and to contribute collectively.

p_____n’s picture

p_____n CreditAttribution: p_____n commented
FileSize
drupal_6811.72 KB

The part considered for function t() to be required was edited briefly.
Thank you for your consideration.

Steven’s picture

Steven CreditAttribution: Steven commented

A modified version with suggestions by Stefan was applied to CVS.

p_____n’s picture

p_____n CreditAttribution: p_____n commented
Title: filter.module & throttle.module t(".....")　was added. » code is not good.

The following code is not good.
The string which should be displayed on this place is "Edit moderation option" ro "Add new moderation option".Therefore, only "Edit" or "Add new" is translated.

-  $output .= '<br /><h3>'. (isset($mid) ? 'Edit' : 'Add new') .' moderation option</h3>';
+  $output .= '<br /><h3>'. (isset($mid) ? t('Edit') : t('Add new')) .' moderation option</h3>';

-  $output .= '<br /><h3>'. (isset($fid) ? 'Edit' : 'Add new') .' threshold</h3>';
+  $output .= '<br /><h3>'. (isset($fid) ? t('Edit') : t('Add new')) .' threshold</h3>';

The reason performed as follows is that the "Edit moderation option" or "Add new moderation option" string sequence wanted it.
Although possibly how to write a code was somewhat forcing, it moved by my site well.

-  $output .= '<br /><h3>'. (isset($mid) ? 'Edit' : 'Add new') .' moderation option</h3>';
+  $output .= '<br /><h3>'. t((isset($mid) ? 'Edit' : 'Add new') .' moderation option').'</h3>';

-  $output .= '<br /><h3>'. (isset($fid) ? 'Edit' : 'Add new') .' threshold</h3>';
+  $output .= '<br /><h3>'.t((isset($fid) ? 'Edit' : 'Add new') .' threshold').'</h3>';
p_____n’s picture

p_____n CreditAttribution: p_____n commented
Title: code is not good. » filter.module & throttle.module t(".....")　was added.

I am sorry. The title has changed.

Steven’s picture

Steven CreditAttribution: Steven commented

Fixed in cvs.

p_____n’s picture

p_____n CreditAttribution: p_____n commented

#5 is not being fixed.

-  $output .= '<h3>Initial comment scores</h3>';
+  $output .= '<h3>'.t('Initial comment scores').'</h3>';
Anonymous’s picture

(not verified) CreditAttribution: commented